Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2259773002: binding: Moves the check for the first access to the initial document into BindingSecurity. (Closed)

Created:
4 years, 4 months ago by Yuki
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

binding: Moves the check for the first access to the initial document into BindingSecurity. Checks the access to the initial document and reports it not only at securityCheck() in V8Window.cpp but also at every call to BindingSecurity::shouldAllowAccessTo() because V8 only calls back securityCheck() on property lookups, and not for function invocation. BindingSecurity::shouldAllowAccessTo() is called with every possible cross-origin window, which means every possible new window. Thus, shouldAllowAccessTo() should be the right place to check the access to the initial document. BUG=630662 Review-Url: https://codereview.chromium.org/2209303002 Cr-Commit-Position: refs/heads/master@{#412195} (cherry picked from commit b8dcfeb065bbfd777cdc5f5433da9a87f25e6ec6) Committed: https://chromium.googlesource.com/chromium/src/+/f9fcdb4834702f6e56d5bbbaf7ee9150884bebde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -44 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 1 chunk +9 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java View 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp View 8 chunks +37 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface_base.cpp View 1 chunk +1 line, -13 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Yuki
4 years, 4 months ago (2016-08-18 08:12:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9fcdb4834702f6e56d5bbbaf7ee9150884bebde.

Powered by Google App Engine
This is Rietveld 408576698