Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7298)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 2259773002: binding: Moves the check for the first access to the initial document into BindingSecurity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 298e804c30e931dbc9e8c09395cce0ebf000d185..eec35df3475ce169df783c9956d1ac91debe2bc7 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -1896,11 +1896,11 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestCloseTabWithUnsafePopup) {
nav_observer.Wait();
// Since the popup is showing an interstitial, it shouldn't have a last
// committed entry.
+ content::WaitForInterstitialAttach(popup);
EXPECT_FALSE(popup->GetController().GetLastCommittedEntry());
ASSERT_TRUE(popup->GetController().GetVisibleEntry());
EXPECT_EQ(https_server_expired_.GetURL("/ssl/bad_iframe.html"),
popup->GetController().GetVisibleEntry()->GetURL());
- content::WaitForInterstitialAttach(popup);
EXPECT_TRUE(popup->ShowingInterstitialPage());
// Add another tab to make sure the browser does not exit when we close
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698