Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_unittest.cc
diff --git a/chrome/browser/prerender/prerender_unittest.cc b/chrome/browser/prerender/prerender_unittest.cc
index 71bd3c70b24df89af49ab905c29c3a4161ea3e27..ce54316e1c75be3de5566ff5732c158e76f4e2e0 100644
--- a/chrome/browser/prerender/prerender_unittest.cc
+++ b/chrome/browser/prerender/prerender_unittest.cc
@@ -59,7 +59,7 @@ class DummyPrerenderContents : public PrerenderContents {
~DummyPrerenderContents() override;
void StartPrerendering(
- const gfx::Size& size,
+ const gfx::Rect& bounds,
content::SessionStorageNamespace* session_storage_namespace) override;
bool GetChildId(int* child_id) const override {
@@ -291,7 +291,7 @@ DummyPrerenderContents::~DummyPrerenderContents() {
}
void DummyPrerenderContents::StartPrerendering(
- const gfx::Size& size,
+ const gfx::Rect& bounds,
content::SessionStorageNamespace* session_storage_namespace) {
// In the base PrerenderContents implementation, StartPrerendering will
// be called even when the PrerenderManager is part of the control group,
@@ -1098,7 +1098,7 @@ TEST_F(PrerenderTest, PrerenderNotAllowedOnCellularWithExternalOrigin) {
FINAL_STATUS_MANAGER_SHUTDOWN);
std::unique_ptr<PrerenderHandle> prerender_handle(
prerender_manager()->AddPrerenderFromExternalRequest(
- url, content::Referrer(), nullptr, kSize));
+ url, content::Referrer(), nullptr, gfx::Rect(kSize)));
EXPECT_FALSE(prerender_handle);
EXPECT_FALSE(prerender_contents->prerendering_has_started());
}
@@ -1128,7 +1128,7 @@ TEST_F(PrerenderTest, PrerenderAllowedForOfflineAndForcedCellular) {
url, origin, FINAL_STATUS_USED);
prerender_handle =
prerender_manager()->AddPrerenderOnCellularFromExternalRequest(
- url, content::Referrer(), nullptr, kSize);
+ url, content::Referrer(), nullptr, gfx::Rect(kSize));
}
EXPECT_TRUE(prerender_handle);
EXPECT_TRUE(prerender_handle->IsPrerendering());

Powered by Google App Engine
This is Rietveld 408576698