Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3096)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
index 3d9de3f87b293ebbc6d6429b5fb00dd93d3bf9dc..898b16693e72366b0f63b30499e58250d6265e5f 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.test.util;
+import android.graphics.Rect;
+
import junit.framework.Assert;
import org.chromium.base.ThreadUtils;
@@ -94,10 +96,11 @@ public class PrerenderTestHelper {
ExternalPrerenderHandler prerenderHandler = new ExternalPrerenderHandler();
boolean didPrerender = prerenderHandler.addPrerender(
currentTab.getProfile(), currentTab.getWebContents(), testUrl, null,
+ new Rect(0, 0,
currentTab.getContentViewCore().getRenderCoordinates()
Benoit L 2016/08/19 12:49:49 nit: the indentation looks funny here.
Yusuf 2016/08/19 17:20:33 Done.
.getContentWidthPixInt(),
currentTab.getContentViewCore().getRenderCoordinates()
- .getContentHeightPixInt(),
+ .getContentHeightPixInt()),
false);
Assert.assertTrue("Failed to prerender test url: " + testUrl, didPrerender);
return prerenderHandler;

Powered by Google App Engine
This is Rietveld 408576698