third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h - Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add opacity check Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

index bd7baaed155b2d2f464dc65f7a080baf4aa48cbb..8d03079a6f89d678839186c6092ab1eb46d21dc0 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h

@@ -217,13 +217,6 @@ public:

void adjustForCompositedScrolling(const GraphicsLayer*, IntSize& offset) const;

- // Returns true for layers with scrollable overflow which have a background

- // that can be painted into the composited scrolling contents layer (i.e.

- // the background can scroll with the content). When the background is also

- // opaque this allows us to composite the scroller even on low DPI as we can

- // draw with subpixel anti-aliasing.

- bool shouldPaintBackgroundOntoScrollingContentsLayer() const;

private:

IntRect recomputeInterestRect(const GraphicsLayer*) const;

static bool interestRectChangedEnoughToRepaint(const IntRect& previousInterestRect, const IntRect& newInterestRect, const IntSize& layerSize);