third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add opacity check Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index a6f845941eaaee947c68515fe29fc3273ab92a03..b24df82e84239c6bdaf4afea5992473536e1a737 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -434,7 +434,7 @@ void LayoutBoxModelObject::setBackingNeedsPaintInvalidationInRect(const LayoutRe

} else if (object.compositedScrollsWithRespectTo(*this)) {

layer()->compositedLayerMapping()->setScrollingContentsNeedDisplayInRect(r, invalidationReason, object);

} else if (usesCompositedScrolling()) {

- if (layer()->compositedLayerMapping()->shouldPaintBackgroundOntoScrollingContentsLayer()) {

+ if (layer()->shouldPaintBackgroundOntoScrollingContentsLayer()) {

// TODO(flackr): Get a correct rect in the context of the scrolling contents layer to update

// rather than updating the entire rect.

const LayoutRect& scrollingContentsRect = toLayoutBox(this)->layoutOverflowRect();