third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp - Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the tests. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

index 8d80825f23199f2d5d01d3ce2e10c3a0149aeaa6..da7437c044fdb64ae6f243c5057bff31bb0cdf27 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp

@@ -47,8 +47,8 @@ protected:

bool shouldPaintBackgroundOntoScrollingContentsLayer(const char* elementId)

{

- CompositedLayerMapping* mapping = toLayoutBlock(getLayoutObjectByElementId(elementId))->layer()->compositedLayerMapping();

- return mapping->shouldPaintBackgroundOntoScrollingContentsLayer();

+ PaintLayer* paintLayer = toLayoutBlock(getLayoutObjectByElementId(elementId))->layer();

+ return paintLayer->shouldPaintBackgroundOntoScrollingContentsLayer();

flackr 2016/08/30 21:14:49 We should probably move the tests rather than have

Stephen Chennney 2016/08/31 20:50:20 Done.

}

private: