Chromium Code Reviews Chromium Code Reviews
Issue 2259493004:
Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html |
| diff --git a/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html |
| index ac1de10ab5c0fa8c5306df080fcb1fd207d66297..53344cf7480a911371c6b4f95efa77d293d29966 100644 |
| --- a/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html |
| +++ b/third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html |
| @@ -1,6 +1,12 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
|
flackr
2016/08/30 21:14:49
I've been discouraged in the past from adding thes
Stephen Chennney
2016/08/31 20:50:20
Opinions differ, but since the other tests in this
|
| <script> |
| if (window.testRunner) |
| - window.testRunner.dumpAsText(); |
| + testRunner.dumpAsText(); |
| + |
| +if (window.internals) |
| + internals.runtimeFlags.compositeOpaqueScrollersEnabled = true; |
| function hasOpaqueCompositedScrollingContentsLayer(layer) { |
| if (layer.name == "Scrolling Contents Layer") |
| @@ -24,7 +30,7 @@ onload = function() { |
| result += "Pass.\n"; |
| else |
| result += "Fail.\n"; |
| - window.testRunner.setCustomTextOutput(result); |
| + testRunner.setCustomTextOutput(result); |
| } |
| </script> |
| <style> |
| @@ -34,15 +40,17 @@ onload = function() { |
| overflow: scroll; |
| width: 200px; |
| height: 200px; |
| - will-change: transform; |
| } |
| .spacer { |
| height: 300px; |
| } |
| </style> |
| +</head> |
| +<body> |
| <!-- The scroller's Scrolling Contents Layer should be opaque due to the opaque |
| color background. Even though the background has a content-box clip there |
| is no gap because the scroller has no padding. This means that we will be |
| able to draw text with subpixel anti-aliasing. |
| --> |
| <div id="scroller"><div class="spacer"></div></div> |
| +</body></html> |
