Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3095)

Unified Diff: chrome/common/variations/fieldtrial_testing_config_schema.json

Issue 2259443003: Capture All Groups in the Field Trial For Testing Studies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback and Change NOTREACHED() to DLOG(ERROR) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/variations/fieldtrial_testing_config_schema.json
diff --git a/chrome/common/variations/fieldtrial_testing_config_schema.json b/chrome/common/variations/fieldtrial_testing_config_schema.json
index 3f165735518e7db198091393739d3099e71b1431..7974e5e0f66a3e972c3d1710cf1a3d6474e54148 100644
--- a/chrome/common/variations/fieldtrial_testing_config_schema.json
+++ b/chrome/common/variations/fieldtrial_testing_config_schema.json
@@ -5,37 +5,47 @@
{
"type_name": "FieldTrialTestingConfig",
"schema": [{
- "field": "groups",
+ "field": "studies",
jwd 2016/08/22 21:54:08 I disagree with Ilya, the terminology is either (s
robliao 2016/08/22 22:55:23 Done. Variations uses trial and group too, so it m
"type": "array",
"contents": {
- "type_name": "FieldTrialTestingGroup",
+ "type_name": "FieldTrialTestingStudy",
"type": "struct",
"fields": [
- {"field": "study", "type": "string"},
- {"field": "group_name", "type": "string"},
+ {"field": "name", "type": "string"},
{
- "field": "params",
+ "field": "groups",
"type": "array",
"contents": {
- "type_name": "FieldTrialGroupParams",
+ "type_name": "FieldTrialTestingGroup",
"type": "struct",
"fields": [
- {"field": "key", "type": "string"},
- {"field": "value", "type": "string"}
+ {"field": "name", "type": "string"},
+ {
+ "field": "params",
+ "type": "array",
+ "contents": {
+ "type_name": "FieldTrialTestingGroupParams",
+ "type": "struct",
+ "fields": [
+ {"field": "key", "type": "string"},
+ {"field": "value", "type": "string"}
+ ]
+ }
+ },
+ {
+ "field": "enable_features",
+ "type": "array",
+ "contents": { "type": "string"}
+ },
+ {
+ "field": "disable_features",
+ "type": "array",
+ "contents": { "type": "string"}
+ }
]
}
- },
- {
- "field": "enable_features",
- "type": "array",
- "contents": { "type": "string"}
- },
- {
- "field": "disable_features",
- "type": "array",
- "contents": { "type": "string"}
}
]
}
}]
-}
+}
« no previous file with comments | « no previous file | chrome/common/variations/variations_util.cc » ('j') | chrome/common/variations/variations_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698