mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406, 614182, 615155, 616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/828394031639b3305df4fbae8a41d6c730003262
Cr-Commit-Position: refs/heads/master@{#415378}

[msw, 2016-08-19 22:12:55]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegate impl to mojo:ash.

BUG=557406,615155
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org
==========

[msw, 2016-08-19 22:12:55]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-19 22:13:09]

Hey James, please take a look; thanks!

[msw, 2016-08-19 22:13:14]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 22:14:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-19 22:14:24]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org
==========

[James Cook, 2016-08-19 22:43:31]

LGTM with nits. Nice CL, great to see this coming together.

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
File ash/public/interfaces/shelf.mojom (right):

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
ash/public/interfaces/shelf.mojom:17: AddObserver(associated ShelfObserver
observer);
Does the observer get notified with the current state when it is added? Might
want to document that.

(I'm a stickler for docs in mojom/IDL files.)

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
ash/public/interfaces/shelf.mojom:19: SetAlignment(ShelfAlignment alignment,
int64 display_id);
Q: Where does Chrome set the alignment/auto-hide behavior? When it loads the
setting from profile storage?

Also, these methods could use some short docs, maybe referring to WmShelf for
details.

https://codereview.chromium.org/2259153002/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (right):

https://codereview.chromium.org/2259153002/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:85: Profile*
profile = ProfileManager::GetActiveUserProfile();
nit: Move this back up to 75 and pass the profile* into OnShelfCreated(), as
GetActiveUserProfile does a little bit of work that would be nice to avoid
repeating.

[msw, 2016-08-19 23:03:43]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org
==========

[msw, 2016-08-19 23:03:43]

msw@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[msw, 2016-08-19 23:05:55]

Hey Scott, please take a look at chrome/*, mash/*, mojo/*.
Hey Tom, please take a look at ash/public/interfaces/*.
Thanks!

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
File ash/public/interfaces/shelf.mojom (right):

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
ash/public/interfaces/shelf.mojom:17: AddObserver(associated ShelfObserver
observer);
On 2016/08/19 22:43:31, James Cook (slow reviews) wrote:
> Does the observer get notified with the current state when it is added? Might
> want to document that.
> 
> (I'm a stickler for docs in mojom/IDL files.)

Done.

https://codereview.chromium.org/2259153002/diff/40001/ash/public/interfaces/s...
ash/public/interfaces/shelf.mojom:19: SetAlignment(ShelfAlignment alignment,
int64 display_id);
On 2016/08/19 22:43:31, James Cook (slow reviews) wrote:
> Q: Where does Chrome set the alignment/auto-hide behavior? When it loads the
> setting from profile storage?
> 
> Also, these methods could use some short docs, maybe referring to WmShelf for
> details.

Yeah, ChromeMashShelfController sets the alignment and auto-hide from prefs on
init (chrome startup), and in OnShelfCreated (when displays are connected).

https://codereview.chromium.org/2259153002/diff/40001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (right):

https://codereview.chromium.org/2259153002/diff/40001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:85: Profile*
profile = ProfileManager::GetActiveUserProfile();
On 2016/08/19 22:43:31, James Cook (slow reviews) wrote:
> nit: Move this back up to 75 and pass the profile* into OnShelfCreated(), as
> GetActiveUserProfile does a little bit of work that would be nice to avoid
> repeating.

I'll keep this as-is, since that would require creating a method like
OnShelfCreatedImpl, since OnShelfCreated itself is a mojom interface impl.

[sky, 2016-08-20 16:32:33]

LGTM

https://codereview.chromium.org/2259153002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (right):

https://codereview.chromium.org/2259153002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:147:
shelf_controller_->SetAlignment(
Long term it seems like state about the alignment and auto-hide belong in ash,
not in chrome. Hopefully once we get preferences figured out it'll be easier to
move into ash. Could you at least file a bug about moving some of this to ash.
Low priority and not a blocker in anyway.

[msw, 2016-08-22 17:01:39]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org
==========

[msw, 2016-08-22 17:03:45]

Tom to TBR for minor mojom changes/moves.

https://codereview.chromium.org/2259153002/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc (right):

https://codereview.chromium.org/2259153002/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc:147:
shelf_controller_->SetAlignment(
On 2016/08/20 16:32:33, sky wrote:
> Long term it seems like state about the alignment and auto-hide belong in ash,
> not in chrome. Hopefully once we get preferences figured out it'll be easier
to
> move into ash. Could you at least file a bug about moving some of this to ash.
> Low priority and not a blocker in anyway.

Will do.

[msw, 2016-08-22 17:04:07]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-22 17:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2259153002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-22 17:04:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 17:07:17]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[msw, 2016-08-22 18:05:13]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-22 18:05:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2259153002/#ps80001
(title: "Sync and rebase.")

[commit-bot: I haz the power, 2016-08-22 18:06:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 19:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 19:04:14]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-22 20:11:04]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 20:11:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:04:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-22 22:16:17]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-22 22:16:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2259153002/#ps100001
(title: "Destroy the window manager app before tearing down MD controllers.")

[commit-bot: I haz the power, 2016-08-22 22:16:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:53:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:53:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom Sepez, 2016-08-23 00:01:35]

One question, otherwise LGTM

https://codereview.chromium.org/2259153002/diff/100001/ash/public/interfaces/...
File ash/public/interfaces/shelf.mojom (right):

https://codereview.chromium.org/2259153002/diff/100001/ash/public/interfaces/...
ash/public/interfaces/shelf.mojom:32: OnShelfCreated(int64 display_id);
When introducing a new id, the question is "what's the worst that happens if a
malicious process sends a bogus one?"

[msw, 2016-08-23 19:32:00]

FYI; This change causes our mash browser test to reliably crash, as its skia
image usage triggers a tcmalloc bug ( http://crbug.com/594674 ). I may attempt
to workaround that issue (perhaps by temporarily disabling some shelf icon
functionality) for now, otherwise I may need to delay landing this CL until that
bug is fixed.

https://codereview.chromium.org/2259153002/diff/100001/ash/public/interfaces/...
File ash/public/interfaces/shelf.mojom (right):

https://codereview.chromium.org/2259153002/diff/100001/ash/public/interfaces/...
ash/public/interfaces/shelf.mojom:32: OnShelfCreated(int64 display_id);
On 2016/08/23 00:01:35, Tom Sepez (Offsite til 8-23) wrote:
> When introducing a new id, the question is "what's the worst that happens if a
> malicious process sends a bogus one?"

Great question; I should have been more careful here, and I'm glad you took a
look. ShelfDelegateMus would have crashed on a null ptr dereference if either
ShelfController function was passed an invalid |display_id|. I have now changed
the impl to no-op on an invalid id. It's possible that Chrome sends a pref for a
display that's being torn down, and we don't want to crash on a race condition
like that; no-op seems safe.

The ShelfObserver::OnShelfCreated implementation in ChromeMashShelfController
will fail to find display-specific preferences for invalid display ids, and then
supply default values back to ShelfController/ShelfDelegateMus (which will
no-op). I added a comment.

The ShelfObserver::On*Changed implementations in ChromeMashShelfController will
uselessly store display-specific user preferences for invalid display ids, but
this is done just in case the display is being torn down when the message is
sent, and shouldn't have an adverse effect beyond bloating user preferences for
bogus display ids. I added a comment.

Let me know if anything here seems amiss.

[msw, 2016-08-25 19:46:57]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 19:48:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:04:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-25 20:31:51]

Patchset #10 (id:180001) has been deleted

[msw, 2016-08-25 20:32:00]

Patchset #9 (id:160001) has been deleted

[msw, 2016-08-25 20:32:08]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 20:33:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:12:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:12:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-26 01:04:06]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 01:04:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 02:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 02:58:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-30 17:47:48]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-30 17:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jamescook@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2259153002/#ps240001
(title: "Sync and rebase.")

[commit-bot: I haz the power, 2016-08-30 17:48:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:57:45]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 18:57:47]

Committed patchset #11 (id:240001)

[commit-bot: I haz the power, 2016-08-30 18:59:17]

Description was changed from

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org
==========

to

==========
mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

Migrate ash/sysui/shelf_delegate_mus.* to ash/mus.
Move mash/shelf/public/interfaces to ash/public/interfaces.
Merge shelf_constants.mojom and shelf.mojom.

Add ShelfController/ShelfObserver multi-display support.
Add ShelfObserver::OnShelfCreated mojo interface.
Add EnumTraits for alignment and auto-hide behavior.

Remove redundant ash/shelf_layout_manager*
Inline RootWindowController::OnShelfWindowAvailable.

BUG=557406,614182,615155,616857
TEST=Mash shelf shows chrome icon; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=tsepez@chromium.org

Committed: https://crrev.com/828394031639b3305df4fbae8a41d6c730003262
Cr-Commit-Position: refs/heads/master@{#415378}
==========

[commit-bot: I haz the power, 2016-08-30 18:59:19]

Patchset 11 (id:??) landed as
https://crrev.com/828394031639b3305df4fbae8a41d6c730003262
Cr-Commit-Position: refs/heads/master@{#415378}