mash: Port ash_sysui ShelfDelegateMus impl to mojo:ash.

ash/public/interfaces/shelf.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-module mash.shelf.mojom;
+module ash.mojom;
 
-import "mash/shelf/public/interfaces/shelf_constants.mojom";
 import "skia/public/interfaces/bitmap.mojom";
 
-// TODO(msw): Add support for multiple displays (with unified and multi-shelf).
+// These values match ash::ShelfAlignment.
+enum ShelfAlignment { BOTTOM, LEFT, RIGHT, BOTTOM_LOCKED, };
 
-// The Shelf controller allows clients (eg. Chrome) to control the mash shelf.
+// These values match ash::ShelfAutoHideBehavior.
+enum ShelfAutoHideBehavior { ALWAYS, NEVER, HIDDEN, };
+
+// The Shelf controller allows clients (eg. Chrome) to control the ash shelf.
 interface ShelfController {
   AddObserver(associated ShelfObserver observer);

[James Cook, 2016/08/19 22:43:31]

Does the observer get notified with the current state when it is added? Might
want to document that.

(I'm a stickler for docs in mojom/IDL files.)

[msw, 2016/08/19 23:05:54]

Done.

 
-  SetAlignment(Alignment alignment);
-  SetAutoHideBehavior(AutoHideBehavior auto_hide);
+  SetAlignment(ShelfAlignment alignment, int64 display_id);

[James Cook, 2016/08/19 22:43:31]

Q: Where does Chrome set the alignment/auto-hide behavior? When it loads the
setting from profile storage?

Also, these methods could use some short docs, maybe referring to WmShelf for
details.

[msw, 2016/08/19 23:05:54]

Yeah, ChromeMashShelfController sets the alignment and auto-hide from prefs on
init (chrome startup), and in OnShelfCreated (when displays are connected).

+  SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide, int64 display_id);
 
   PinItem(ShelfItem item, associated ShelfItemDelegate delegate);
   UnpinItem(string app_id);
 
   SetItemImage(string app_id, skia.mojom.Bitmap image);
 };
 
 // ShelfObserver is notified on shelf changes; used to persist profile settings.
 interface ShelfObserver {
-  OnAlignmentChanged(Alignment alignment);
-  OnAutoHideBehaviorChanged(AutoHideBehavior auto_hide);
+  OnShelfCreated(int64 display_id);
+  OnAlignmentChanged(ShelfAlignment alignment, int64 display_id);
+  OnAutoHideBehaviorChanged(ShelfAutoHideBehavior auto_hide, int64 display_id);
 };
 
 // ShelfItemDelegate handles command execution and observes shelf item changes.
 interface ShelfItemDelegate {
   // Called when a pinned shelf item is invoked without an open window.
   LaunchItem();
 
   // Called on invocation of a shelf item's context menu command.
   ExecuteCommand(uint32 command_id, int32 event_flags);
 
@@ skipping 26 matching lines @@
 
   // A app title, used for tooltips, etc. (eg. 'Foo Application').
   string app_title;
 
   // An icon image Bitmap, shown on the shelf.
   skia.mojom.Bitmap image;
 
   // Additional context menu items (eg. 'New Incognito Window').
   array<ContextMenuItem>? context_menu_items;
 };