Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2259143002: Add 10 Skia methods to CFI blacklist for perf reasons. (Closed)

Created:
4 years, 4 months ago by krasin
Modified:
4 years, 4 months ago
Reviewers:
krasin1, kcc2
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 10 Skia methods to CFI blacklist for perf reasons. While they have not been observed to slow down real-world use cases, some blink_layout microbenchmarks feel better with these methods disabled. In order to be concervative at the launch time, lift the CFI defense for these methods. BUG=634139 Committed: https://crrev.com/4e341f5368a22ceeab4d5133f03ec6a71729737f Cr-Commit-Position: refs/heads/master@{#412979}

Patch Set 1 #

Patch Set 2 : Move lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M tools/cfi/blacklist.txt View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
krasin1
Hi Kostya, please, review this tiny CL that eliminates CFI perf impact on skia.
4 years, 4 months ago (2016-08-18 22:44:40 UTC) #2
kcc2
lgtm
4 years, 4 months ago (2016-08-18 22:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259143002/20001
4 years, 4 months ago (2016-08-18 22:46:35 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 22:46:37 UTC) #7
krasin1
(self LGTM)
4 years, 4 months ago (2016-08-18 22:46:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259143002/20001
4 years, 4 months ago (2016-08-18 22:47:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 00:08:04 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 00:11:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e341f5368a22ceeab4d5133f03ec6a71729737f
Cr-Commit-Position: refs/heads/master@{#412979}

Powered by Google App Engine
This is Rietveld 408576698