Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/cfi/blacklist.txt

Issue 2259143002: Add 10 Skia methods to CFI blacklist for perf reasons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move lines Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cfi/blacklist.txt
diff --git a/tools/cfi/blacklist.txt b/tools/cfi/blacklist.txt
index cb0b24f1305b7fef9e4e707cb67bcd7591d1fda5..babe7bd6ef6b3a8e49c4ad58c3cea34603bdcee6 100644
--- a/tools/cfi/blacklist.txt
+++ b/tools/cfi/blacklist.txt
@@ -62,3 +62,32 @@ src:*LifecycleObserver.h*
# https://crbug.com/568891
src:*wtf/Vector.h*
src:*wtf/PartitionAllocator.h*
+
+#############################################################################
+# Methods disabled due to perf considerations.
+
+# Skia
+
+# https://crbug.com/638064#c1
+fun:*SkPictureUtils::ApproximateBytesUsed*
+
+# https://crbug.com/638056#c1
+fun:*SkCanvas::onDrawRect*
+
+# https://crbug.com/638064
+fun:*SkCanvas::drawPicture*
+
+# https://crbug.com/638060
+fun:*SkCanvas::onDrawPicture*
+
+# https://crbug.com/638064#c2
+fun:*SkBaseDevice::accessPixels*
+
+# https://crbug.com/638056
+fun:*call_hline_blitter*
+fun:*do_scanline*
+fun:*antifilldot8*
+
+# Unclear what could be done here
+fun:*SkCanvas::drawRect*
+fun:*SkPictureGpuAnalyzer::analyzePicture*
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698