Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2259083002: cc: Correct elastic overscroll synchronization. (Closed)

Created:
4 years, 4 months ago by Khushal
Modified:
4 years, 4 months ago
Reviewers:
danakj, esprehn
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Correct elastic overscroll synchronization. The |elastic_overscroll_| was moved to LayerTree in this change (https://codereview.chromium.org/2183403002), and is being used for synchronization during commit, but it wasn't deleted from LayerTreeHost and was incorrectly used when building PropertyTrees and applying the delta during BeginMainFrame. BUG=639046 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a Cr-Commit-Position: refs/heads/master@{#413272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M cc/proto/layer_tree.proto View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/proto/layer_tree_host.proto View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_serialization.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Khushal
4 years, 4 months ago (2016-08-18 21:05:52 UTC) #3
danakj
LGTM
4 years, 4 months ago (2016-08-19 18:55:38 UTC) #4
esprehn
Can we revert while we wait on this patch? Canary is unusable right now.
4 years, 4 months ago (2016-08-19 18:57:43 UTC) #6
esprehn
hah, or land it... is there tests that are missing to make sure it doesn't ...
4 years, 4 months ago (2016-08-19 18:58:08 UTC) #7
Khushal
On 2016/08/19 18:55:38, danakj wrote: > LGTM Thanks!
4 years, 4 months ago (2016-08-19 18:59:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259083002/1
4 years, 4 months ago (2016-08-19 19:00:09 UTC) #10
Khushal
On 2016/08/19 18:58:08, esprehn wrote: > hah, or land it... is there tests that are ...
4 years, 4 months ago (2016-08-19 19:03:27 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-19 21:23:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259083002/1
4 years, 4 months ago (2016-08-19 22:40:47 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 22:45:46 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:47:17 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f70f776fa8c14b5d684e39a85766dbef3f6e002a
Cr-Commit-Position: refs/heads/master@{#413272}

Powered by Google App Engine
This is Rietveld 408576698