cc: Move data to LayerTree from LayerTreeHost.

cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b
Cr-Commit-Position: refs/heads/master@{#412413}

[Khushal, 2016-07-27 06:36:30]

Description was changed from

==========
cc: Move viewport layers registration to LayerTree from LayerTreeHost.

BUG=628683
==========

to

==========
cc: Move viewport layers registration to LayerTree from LayerTreeHost.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[khushalsagar, 2016-07-27 06:37:01]

The CQ bit was checked by khushalsagar@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:37:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:38:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 06:38:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Khushal, 2016-08-01 22:36:42]

Description was changed from

==========
cc: Move viewport layers registration to LayerTree from LayerTreeHost.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-08-01 22:37:08]

Description was changed from

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[Khushal, 2016-08-01 22:41:54]

khushalsagar@chromium.org changed reviewers:
+ enne@chromium.org
- khushalsagar@google.com

[Khushal, 2016-08-01 22:41:55]

This moves bulk of what should go to the LayerTree from the host. Vlad also
suggested that we can move whatever can be shared between the remote and direct
version of LTH to LayerTree. And then have the one LayerTreeHost interface which
will have methods that need to be used internally in cc and what the embedders
need, may be friending things to restrict access.

I still have to update the test code and external callers for this change
properly, please ignore those files in the patch. Could you take a look at the
rest and see if it looks good.

[Khushal, 2016-08-08 16:55:33]

friendly ping. :)

[enne (OOO), 2016-08-08 17:52:16]

Sorry for the delay.

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:157: //
-----------------------------------------------------------------
If this is supposed to be part of the above block, just don't add a blank line
between it and the block instead of adding hyphens everywhere (on this line, and
the above one?)

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:220: gfx::Vector2dF elastic_overscroll() const {
return elastic_overscroll_; }
Why isn't this part of LayerTree? It seems like it's part of LayerTreeImpl?

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:408: // Layer tree that hold layers.
I think you mean "holds", although I'm not sure that this comment adds anything.

[Khushal, 2016-08-08 23:21:37]

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:157: //
-----------------------------------------------------------------
On 2016/08/08 17:52:16, enne wrote:
> If this is supposed to be part of the above block, just don't add a blank line
> between it and the block instead of adding hyphens everywhere (on this line,
and
> the above one?)

Sure, will do. whatever is cleaner. :)

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:220: gfx::Vector2dF elastic_overscroll() const {
return elastic_overscroll_; }
On 2016/08/08 17:52:16, enne wrote:
> Why isn't this part of LayerTree? It seems like it's part of LayerTreeImpl?

Probably missed it because I didn't see this being set other than during the
BeginMainFrame. Btw, Where is this value mutated on the main thread?

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:408: // Layer tree that hold layers.
On 2016/08/08 17:52:16, enne wrote:
> I think you mean "holds", although I'm not sure that this comment adds
anything.

Copied the comment from below. I'll remove it.

[enne (OOO), 2016-08-09 18:21:08]

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:220: gfx::Vector2dF elastic_overscroll() const {
return elastic_overscroll_; }
On 2016/08/08 at 23:21:37, Khushal wrote:
> On 2016/08/08 17:52:16, enne wrote:
> > Why isn't this part of LayerTree? It seems like it's part of LayerTreeImpl?
> 
> Probably missed it because I didn't see this being set other than during the
BeginMainFrame. Btw, Where is this value mutated on the main thread?

https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host.cc?sq=package:c...

[enne (OOO), 2016-08-09 18:21:54]

On 2016/08/09 at 18:21:08, enne wrote:
>
https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_host.h
> File cc/trees/layer_tree_host.h (right):
> 
>
https://codereview.chromium.org/2183403002/diff/40001/cc/trees/layer_tree_hos...
> cc/trees/layer_tree_host.h:220: gfx::Vector2dF elastic_overscroll() const {
return elastic_overscroll_; }
> On 2016/08/08 at 23:21:37, Khushal wrote:
> > On 2016/08/08 17:52:16, enne wrote:
> > > Why isn't this part of LayerTree? It seems like it's part of
LayerTreeImpl?
> > 
> > Probably missed it because I didn't see this being set other than during the
BeginMainFrame. Btw, Where is this value mutated on the main thread?
> 
>
https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host.cc?sq=package:c...

It's only there, in BeginMainFrame.  It just seems like logically it's a part of
the LayerTree since it's also a per-LayerTreeImpl setting.

[Khushal, 2016-08-12 06:49:42]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 06:49:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 06:49:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 06:49:52]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * master.tryserver.blink builder linux_blink_rel was renamed to
linux_precise_blink_rel (http://crbug.com/590036)

[Khushal, 2016-08-12 06:52:31]

Description was changed from

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[Khushal, 2016-08-12 06:52:40]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 06:52:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 07:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 07:06:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Khushal, 2016-08-12 07:13:28]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 07:13:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 07:26:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 07:26:15]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Khushal, 2016-08-12 18:11:25]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 18:12:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:03:44]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-08-12 21:02:58]

All done. I rebased too since this is changing a lot of call sites mostly. PTAL.
Thanks!

[Khushal, 2016-08-16 02:09:29]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 02:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-08-16 02:55:40]

loyso@chromium.org changed reviewers:
+ loyso@chromium.org

[loyso (OOO), 2016-08-16 02:55:41]

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host.cc:461:
layer_tree_->animation_host()->PushPropertiesTo(
Notice that AnimationHost is owned by LayerTree, but
AnimationHost::PushProperties is not a part of
LayerTree::PushPropertiesTo(LayerTreeImpl*).

[Khushal, 2016-08-16 04:28:53]

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host.cc:461:
layer_tree_->animation_host()->PushPropertiesTo(
On 2016/08/16 02:55:41, loyso wrote:
> Notice that AnimationHost is owned by LayerTree, but
> AnimationHost::PushProperties is not a part of
> LayerTree::PushPropertiesTo(LayerTreeImpl*).

It can be done there too, we can just pass the impl AnimationHost. Though there
is already so much we do differently for the commit that doing it here looks
fine too. Or have the animation host owned here but the MutatorHostClient can
still be implemented by the tree. You were planning on having it be a weak
reference and moving the ownership out to the
RenderWidgetCompositor/ui::Compositor anyway right?

[commit-bot: I haz the power, 2016-08-16 04:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 04:30:47]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-08-16 17:38:29]

khushalsagar@chromium.org changed reviewers:
+ piman@chromium.org, vollick@chromium.org

[Khushal, 2016-08-16 17:38:30]

+vollick for Webkit.
+piman for content.

[piman, 2016-08-16 18:28:57]

rs LGTM for content/ and ui/compositor, modulo review by others for cc/

[enne (OOO), 2016-08-16 20:58:53]

lgtm

[Ian Vollick, 2016-08-16 21:11:46]

On 2016/08/16 at 20:58:53, enne wrote:
> lgtm

platform/ lgtm.

[Khushal, 2016-08-16 21:47:37]

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/2183403002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host.cc:461:
layer_tree_->animation_host()->PushPropertiesTo(
On 2016/08/16 04:28:53, Khushal wrote:
> On 2016/08/16 02:55:41, loyso wrote:
> > Notice that AnimationHost is owned by LayerTree, but
> > AnimationHost::PushProperties is not a part of
> > LayerTree::PushPropertiesTo(LayerTreeImpl*).
> 
> It can be done there too, we can just pass the impl AnimationHost. Though
there
> is already so much we do differently for the commit that doing it here looks
> fine too. Or have the animation host owned here but the MutatorHostClient can
> still be implemented by the tree. You were planning on having it be a weak
> reference and moving the ownership out to the
> RenderWidgetCompositor/ui::Compositor anyway right?

I'll land this now because this change is mostly moving a lot of call sites and
I don't want more to creep in. Feel free to comment here, I can take those up in
a subsequent change. Thanks.

[Khushal, 2016-08-16 21:47:45]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-08-16 21:47:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, enne@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2183403002/#ps140001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-08-16 21:48:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2016-08-16 23:07:39]

The CQ bit was unchecked by khushalsagar@chromium.org

[Khushal, 2016-08-16 23:17:20]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-08-16 23:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
vollick@chromium.org, enne@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2183403002/#ps160001
(title: "remove unused test file.")

[commit-bot: I haz the power, 2016-08-16 23:18:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 01:36:48]

Description was changed from

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-17 01:36:49]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-17 01:38:14]

Description was changed from

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Move data to LayerTree from LayerTreeHost.

Move bulk of the tree state from LayerTreeHost to LayerTree. The
LayerTree mirrors LayerTreeImpl in terms of what it stores and is used
to push the corresponding properties to LayerTreeImpl during commit.

BUG=628683
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b
Cr-Commit-Position: refs/heads/master@{#412413}
==========

[commit-bot: I haz the power, 2016-08-17 01:38:15]

Patchset 9 (id:??) landed as
https://crrev.com/806556451c84f03082ece3818862bbc22fd2727b
Cr-Commit-Position: refs/heads/master@{#412413}

[Reid Kleckner, 2016-08-17 17:04:44]

rnk@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2016-08-17 17:04:46]

https://codereview.chromium.org/2183403002/diff/160001/cc/layers/layer_unitte...
File cc/layers/layer_unittest.cc (right):

https://codereview.chromium.org/2183403002/diff/160001/cc/layers/layer_unitte...
cc/layers/layer_unittest.cc:945: layer_tree_ =
static_cast<StrictMock<MockLayerTree>*>(
This cast is invalid:
https://build.chromium.org/p/chromium.fyi/builders/UBSanVptr%20Linux/builds/1...

../../cc/layers/layer_unittest.cc:945:19: runtime error: downcast of address
0x2b620bc69e00 which does not point to an object of type
'StrictMock<cc::(anonymous namespace)::MockLayerTree>'
0x2b620bc69e00: note: object is of type 'cc::(anonymous
namespace)::MockLayerTree'
 00 00 00 00  98 a1 02 03 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00
00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'cc::(anonymous namespace)::MockLayerTree'

[Reid Kleckner, 2016-08-17 17:07:46]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2253143002/ by rnk@chromium.org.

The reason for reverting is: Invalid cast breaks CFI build, which is shipping on
Linux soon.