Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: explicitly check if task_start_time was set Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
index 4c03d296471113407836d8569137dd3211e4fe4c..0da190b8c6e3bc1c3dce5d0206267fa5b8fca324 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
@@ -24,7 +24,7 @@
#include "platform/scheduler/base/task_queue_manager_delegate_for_test.h"
#include "platform/scheduler/base/task_queue_selector.h"
#include "platform/scheduler/base/test_count_uses_time_source.h"
-#include "platform/scheduler/base/test_task_time_tracker.h"
+#include "platform/scheduler/base/test_task_time_observer.h"
#include "platform/scheduler/base/test_time_source.h"
#include "platform/scheduler/base/virtual_time_domain.h"
#include "platform/scheduler/base/work_queue.h"
@@ -78,7 +78,7 @@ class TaskQueueManagerTest : public testing::Test {
manager_ = base::MakeUnique<TaskQueueManager>(
main_task_runner_, "test.scheduler", "test.scheduler",
"test.scheduler.debug");
- manager_->SetTaskTimeTracker(&test_task_time_tracker_);
+ manager_->AddTaskTimeObserver(&test_task_time_observer_);
for (size_t i = 0; i < num_queues; i++)
runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));
@@ -100,7 +100,7 @@ class TaskQueueManagerTest : public testing::Test {
MessageLoopTaskRunner::Create(
base::WrapUnique(new TestTimeSource(now_src_.get()))),
"test.scheduler", "test.scheduler", "test.scheduler.debug");
- manager_->SetTaskTimeTracker(&test_task_time_tracker_);
+ manager_->AddTaskTimeObserver(&test_task_time_observer_);
for (size_t i = 0; i < num_queues; i++)
runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));
@@ -112,7 +112,7 @@ class TaskQueueManagerTest : public testing::Test {
scoped_refptr<cc::OrderedSimpleTaskRunner> test_task_runner_;
std::unique_ptr<TaskQueueManager> manager_;
std::vector<scoped_refptr<internal::TaskQueueImpl>> runners_;
- TestTaskTimeTracker test_task_time_tracker_;
+ TestTaskTimeObserver test_task_time_observer_;
};
void PostFromNestedRunloop(base::MessageLoop* message_loop,
@@ -144,7 +144,7 @@ TEST_F(TaskQueueManagerTest,
base::WrapUnique(test_count_uses_time_source)),
"test.scheduler", "test.scheduler", "test.scheduler.debug");
manager_->SetWorkBatchSize(6);
- manager_->SetTaskTimeTracker(&test_task_time_tracker_);
+ manager_->AddTaskTimeObserver(&test_task_time_observer_);
for (size_t i = 0; i < 3; i++)
runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));
@@ -175,7 +175,7 @@ TEST_F(TaskQueueManagerTest, NowNotCalledForNestedTasks) {
MessageLoopTaskRunner::Create(
base::WrapUnique(test_count_uses_time_source)),
"test.scheduler", "test.scheduler", "test.scheduler.debug");
- manager_->SetTaskTimeTracker(&test_task_time_tracker_);
+ manager_->AddTaskTimeObserver(&test_task_time_observer_);
runners_.push_back(manager_->NewTaskQueue(TaskQueue::Spec("test_queue")));

Powered by Google App Engine
This is Rietveld 408576698