third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h - Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explicitly check if task_start_time was set Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/test_task_time_tracker.h ('k') | third_party/WebKit/Source/platform/scheduler/child/webthread_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

diff --git a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

index c1991af6ebc4491343b17c6bb4e2edf7a0e82317..52cc27554bc62c263bc44462586aa45308db57f0 100644

--- a/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

+++ b/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h

@@ -58,9 +58,14 @@ class BLINK_PLATFORM_EXPORT SchedulerHelper

void AddTaskObserver(base::MessageLoop::TaskObserver* task_observer);

void RemoveTaskObserver(base::MessageLoop::TaskObserver* task_observer);

- void SetTaskTimeTracker(TaskTimeTracker* task_time_tracker) {

+ void AddTaskTimeObserver(TaskTimeObserver* task_time_observer) {

Sami 2016/08/26 16:08:56 nit: Please implement these in the .cc instead.

panicker 2016/08/26 16:24:48 Done.

if (task_queue_manager_)

- task_queue_manager_->SetTaskTimeTracker(task_time_tracker);

+ task_queue_manager_->AddTaskTimeObserver(task_time_observer);

+ }

+ void RemoveTaskTimeObserver(TaskTimeObserver* task_time_observer) {

+ if (task_queue_manager_)

+ task_queue_manager_->RemoveTaskTimeObserver(task_time_observer);

}

// Shuts down the scheduler by dropping any remaining pending work in the work