Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 22589005: Make sure polymorphic element access creates non-replaying phis. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Make sure polymorphic element access creates non-replaying phis. R=danno@chromium.org BUG=v8:2815 Committed: http://code.google.com/p/v8/source/detail?r=16136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Follow-up to: https://codereview.chromium.org/22494003/
7 years, 4 months ago (2013-08-09 09:30:25 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-09 13:40:31 UTC) #2
Michael Starzinger
7 years, 4 months ago (2013-08-09 15:23:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698