Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: src/hydrogen.cc

Issue 22589005: Make sure polymorphic element access creates non-replaying phis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5574 matching lines...) Expand 10 before | Expand all | Expand 10 after
5585 external_elements, checked_key, val, 5585 external_elements, checked_key, val,
5586 mapcompare, elements_kind, is_store); 5586 mapcompare, elements_kind, is_store);
5587 } 5587 }
5588 *has_side_effects |= access->HasObservableSideEffects(); 5588 *has_side_effects |= access->HasObservableSideEffects();
5589 // The caller will use has_side_effects and add a correct Simulate. 5589 // The caller will use has_side_effects and add a correct Simulate.
5590 access->SetFlag(HValue::kHasNoObservableSideEffects); 5590 access->SetFlag(HValue::kHasNoObservableSideEffects);
5591 if (position != RelocInfo::kNoPosition) access->set_position(position); 5591 if (position != RelocInfo::kNoPosition) access->set_position(position);
5592 if (!is_store) { 5592 if (!is_store) {
5593 Push(access); 5593 Push(access);
5594 } 5594 }
5595 NoObservableSideEffectsScope scope(this);
5595 current_block()->GotoNoSimulate(join); 5596 current_block()->GotoNoSimulate(join);
5596 set_current_block(other_map); 5597 set_current_block(other_map);
5597 } 5598 }
5598 5599
5599 // Deopt if none of the cases matched. 5600 // Deopt if none of the cases matched.
5600 NoObservableSideEffectsScope scope(this); 5601 NoObservableSideEffectsScope scope(this);
5601 FinishExitWithHardDeoptimization(join); 5602 FinishExitWithHardDeoptimization(join);
5602 set_current_block(join); 5603 set_current_block(join);
5603 return is_store ? NULL : Pop(); 5604 return is_store ? NULL : Pop();
5604 } 5605 }
(...skipping 4110 matching lines...) Expand 10 before | Expand all | Expand 10 after
9715 if (ShouldProduceTraceOutput()) { 9716 if (ShouldProduceTraceOutput()) {
9716 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9717 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9717 } 9718 }
9718 9719
9719 #ifdef DEBUG 9720 #ifdef DEBUG
9720 graph_->Verify(false); // No full verify. 9721 graph_->Verify(false); // No full verify.
9721 #endif 9722 #endif
9722 } 9723 }
9723 9724
9724 } } // namespace v8::internal 9725 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698