Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: LayoutTests/fast/table/table-toggle-paragraph-padding.html

Issue 22589002: Margins on children of display:table-cell elements get stuck at highest value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Simplify test case with Ref Test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/table/table-toggle-paragraph-padding.html
diff --git a/LayoutTests/fast/table/table-toggle-paragraph-padding.html b/LayoutTests/fast/table/table-toggle-paragraph-padding.html
new file mode 100644
index 0000000000000000000000000000000000000000..c28987a6211857e8a127f341f70a9a4ff1e90b2e
--- /dev/null
+++ b/LayoutTests/fast/table/table-toggle-paragraph-padding.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<style>
+.cell { border: 5px solid pink; }
+.cell .thinger { background-color: salmon; }
Julien - ping for review 2013/08/08 22:15:51 This can be simplified to .thinger { ... } Also t
suchit.agrawal 2013/08/09 11:00:43 Done.
+.cell { display:table-cell; }
+</style>
+
+<body>
+<h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/detail?id=241331">241331</a>. Margins on children of display:table-cell elements get stuck at highest value.</h3>
+<h4>Row's before margin was not reseting back to 0 when margin of the cell's child is changed from 40px to 0.</h4>
Julien - ping for review 2013/08/08 22:15:51 s/40px/100px/
suchit.agrawal 2013/08/09 11:00:43 Done.
+The two blocks below should look identical.
+<br/><br/>
+
+<div>
Julien - ping for review 2013/08/08 22:15:51 Do we really need to use an anonymous table by usi
ojan 2013/08/08 22:19:29 I tried that actually and couldn't get it to repro
suchit.agrawal 2013/08/09 11:00:43 I also tried it with table and td tags. But I am n
+ <div class="cell">a</div>
+ <div class="cell"><div class="thinger">b</div></div>
+</div>
+<br>
+<div>
+ <div class="cell">a</div>
+ <div class="cell"><div class="thinger toggle" style="margin:100px">b</div></div>
+</div>
+
+<script>
+document.body.offsetWidth;
+document.querySelector('.toggle').style.margin = 0;
Julien - ping for review 2013/08/08 22:15:51 This really look like it could be a checkLayout()
suchit.agrawal 2013/08/09 11:00:43 Done.
+</script>
+</body>

Powered by Google App Engine
This is Rietveld 408576698