LayoutTests/fast/table/table-toggle-paragraph-padding.html - Issue 22589002: Margins on children of display:table-cell elements get stuck at highest value.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/table-toggle-paragraph-padding.html

Issue 22589002: Margins on children of display:table-cell elements get stuck at highest value. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Simplify test case with Ref Test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/table/table-toggle-paragraph-padding-expected.html » ('j') | LayoutTests/fast/table/table-toggle-paragraph-padding-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 .cell { border: 5px solid pink; }

	4 .cell .thinger { background-color: salmon; }
	Julien - ping for review 2013/08/08 22:15:51 This can be simplified to .thinger { ... } Also t This can be simplified to .thinger { ... } Also the class name could be improved by just saying what it does: backgroundSalmon. suchit.agrawal 2013/08/09 11:00:43 Done. Show quoted text On 2013/08/08 22:15:51, Julien Chaffraix wrote: > This can be simplified to .thinger { ... } > > Also the class name could be improved by just saying what it does: > backgroundSalmon. Done.
	5 .cell { display:table-cell; }

	6 </style>

	7

	8 <body>

	9 <h3>Test for chromium bug : <a href="https://code.google.com/p/chromium/issues/d etail?id=241331">241331</a>. Margins on children of display:table-cell elements get stuck at highest value.</h3>

	10 <h4>Row's before margin was not reseting back to 0 when margin of the cell's chi ld is changed from 40px to 0.</h4>
	Julien - ping for review 2013/08/08 22:15:51 s/40px/100px/ s/40px/100px/ suchit.agrawal 2013/08/09 11:00:43 Done. Show quoted text On 2013/08/08 22:15:51, Julien Chaffraix wrote: > s/40px/100px/ Done.
	11 The two blocks below should look identical.

	12 <br/><br/>

	13

	14 <div>
	Julien - ping for review 2013/08/08 22:15:51 Do we really need to use an anonymous table by usi Do we really need to use an anonymous table by using CSS instead of explicit <table> / <td> tags? ojan 2013/08/08 22:19:29 I tried that actually and couldn't get it to repro Show quoted text On 2013/08/08 22:15:51, Julien Chaffraix wrote: > Do we really need to use an anonymous table by using CSS instead of explicit > <table> / <td> tags? I tried that actually and couldn't get it to reproduce. I didn't dig into why. suchit.agrawal 2013/08/09 11:00:43 I also tried it with table and td tags. But I am n Show quoted text On 2013/08/08 22:15:51, Julien Chaffraix wrote: > Do we really need to use an anonymous table by using CSS instead of explicit > <table> / <td> tags? I also tried it with table and td tags. But I am not able to reproduce it.
	15 <div class="cell">a</div>

	16 <div class="cell"><div class="thinger">b</div></div>

	17 </div>

	18 <br>

	19 <div>

	20 <div class="cell">a</div>

	21 <div class="cell"><div class="thinger toggle" style="margin:100px">b</div></ div>

	22 </div>

	23

	24 <script>

	25 document.body.offsetWidth;

	26 document.querySelector('.toggle').style.margin = 0;
	Julien - ping for review 2013/08/08 22:15:51 This really look like it could be a checkLayout() This really look like it could be a checkLayout() test instead of a much slower ref-test. suchit.agrawal 2013/08/09 11:00:43 Done. Show quoted text On 2013/08/08 22:15:51, Julien Chaffraix wrote: > This really look like it could be a checkLayout() test instead of a much slower > ref-test. Done.
	27 </script>

	28 </body>

OLD	NEW