Convert http media tests to testharness.js

Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/25f67c81bfa8c6b1ce5a4c061ca5bd76eae32fff
Cr-Commit-Position: refs/heads/master@{#413069}

[Srirama, 2016-08-18 13:20:56]

Description was changed from

==========
fix


fix

BUG=
==========

to

==========
Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-08-18 13:22:37]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-08-18 13:25:59]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-08-18 13:26:00]

This is the last CL and there are no more test cases to be converted for media.

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
(right):

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html:20:
confirm("I hope the movie continues to play!");
will the test framework dismiss the confirm dialog automatically?

[fs, 2016-08-18 14:04:05]

On 2016/08/18 at 13:26:00, srirama.m wrote:
> This is the last CL and there are no more test cases to be converted for
media.

Woohoo!!! \o/

LGTM w/ nits

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html
(right):

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:49:
assert_greater_than(progressCountDelta, 0, 'Progress Event not fired');
'at least one progress event was fired' ? (Instead of 'Progress Event not fired'
which seems backwards.)

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:50:
assert_less_than_equal(progressCountDelta, maxProgressCountIncrease, 'Too many
progress events fired');
Ditto here. (This is asserting that too many events were _not_ fired.)

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:60:
assert_greater_than(msUntilNextCheck, 0, 'Progress Event delayed');
Maybe 'delayed' -> 'delay' or something like that.

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:67:
assert_equals(progressCount, 0, 'Progress Event fired before load event');
'No progress event fired...'

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
(right):

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html:20:
confirm("I hope the movie continues to play!");
On 2016/08/18 at 13:25:59, Srirama wrote:
> will the test framework dismiss the confirm dialog automatically?

IIRC it'll log and return true.

[Srirama, 2016-08-19 04:57:34]

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html
(right):

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:49:
assert_greater_than(progressCountDelta, 0, 'Progress Event not fired');
On 2016/08/18 14:04:05, fs wrote:
> 'at least one progress event was fired' ? (Instead of 'Progress Event not
fired'
> which seems backwards.)

Done. I have given these comments from the perspective that if the test fails we
will see the error message.

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:50:
assert_less_than_equal(progressCountDelta, maxProgressCountIncrease, 'Too many
progress events fired');
On 2016/08/18 14:04:05, fs wrote:
> Ditto here. (This is asserting that too many events were _not_ fired.)

Done.

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:60:
assert_greater_than(msUntilNextCheck, 0, 'Progress Event delayed');
On 2016/08/18 14:04:05, fs wrote:
> Maybe 'delayed' -> 'delay' or something like that.

Done.

https://codereview.chromium.org/2258863002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html:67:
assert_equals(progressCount, 0, 'Progress Event fired before load event');
On 2016/08/18 14:04:05, fs wrote:
> 'No progress event fired...'

Done.

[Srirama, 2016-08-19 04:57:45]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-08-19 04:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2258863002/#ps40001
(title: "address nits")

[commit-bot: I haz the power, 2016-08-19 04:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 06:31:08]

Description was changed from

==========
Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-08-19 06:31:09]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-19 06:32:39]

Description was changed from

==========
Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert http media tests to testharness.js

Cleaning http media tests to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/25f67c81bfa8c6b1ce5a4c061ca5bd76eae32fff
Cr-Commit-Position: refs/heads/master@{#413069}
==========

[commit-bot: I haz the power, 2016-08-19 06:32:41]

Patchset 2 (id:??) landed as
https://crrev.com/25f67c81bfa8c6b1ce5a4c061ca5bd76eae32fff
Cr-Commit-Position: refs/heads/master@{#413069}