android_webview/browser/net/aw_request_interceptor.cc - Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/net/aw_request_interceptor.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc ('k') | android_webview/browser/net/aw_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/net/aw_request_interceptor.cc

diff --git a/android_webview/browser/net/aw_request_interceptor.cc b/android_webview/browser/net/aw_request_interceptor.cc

index fd07a1b6490421c867bc8e2b9e2c004ac6d8ae34..3645f2fefe3321da95684c607d2c7f5868e6ed65 100644

--- a/android_webview/browser/net/aw_request_interceptor.cc

+++ b/android_webview/browser/net/aw_request_interceptor.cc

@@ -101,8 +101,8 @@ class ShouldInterceptRequestAdaptor

void WebResourceResponseObtained(

std::unique_ptr<AwWebResourceResponse> response) {

if (response) {

- callback_.Run(base::WrapUnique(

- new StreamReaderJobDelegateImpl(std::move(response))));

+ callback_.Run(

+ base::MakeUnique<StreamReaderJobDelegateImpl>(std::move(response)));

} else {

callback_.Run(nullptr);

}

@@ -160,8 +160,8 @@ net::URLRequestJob* AwRequestInterceptor::MaybeInterceptRequest(

new base::SupportsUserData::Data());

return new AndroidStreamReaderURLRequestJob(

request, network_delegate,

- base::WrapUnique(

- new ShouldInterceptRequestAdaptor(std::move(io_thread_client))),

+ base::MakeUnique<ShouldInterceptRequestAdaptor>(

+ std::move(io_thread_client)),

true);

}