Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: android_webview/browser/net/aw_request_interceptor.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/browser/net/aw_request_interceptor.h" 5 #include "android_webview/browser/net/aw_request_interceptor.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "android_webview/browser/aw_contents_io_thread_client.h" 9 #include "android_webview/browser/aw_contents_io_thread_client.h"
10 #include "android_webview/browser/input_stream.h" 10 #include "android_webview/browser/input_stream.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 base::Bind(&ShouldInterceptRequestAdaptor::WebResourceResponseObtained, 94 base::Bind(&ShouldInterceptRequestAdaptor::WebResourceResponseObtained,
95 // The lifetime of the DelegateObtainer is managed by 95 // The lifetime of the DelegateObtainer is managed by
96 // AndroidStreamReaderURLRequestJob, it might get deleted. 96 // AndroidStreamReaderURLRequestJob, it might get deleted.
97 weak_factory_.GetWeakPtr())); 97 weak_factory_.GetWeakPtr()));
98 } 98 }
99 99
100 private: 100 private:
101 void WebResourceResponseObtained( 101 void WebResourceResponseObtained(
102 std::unique_ptr<AwWebResourceResponse> response) { 102 std::unique_ptr<AwWebResourceResponse> response) {
103 if (response) { 103 if (response) {
104 callback_.Run(base::WrapUnique( 104 callback_.Run(
105 new StreamReaderJobDelegateImpl(std::move(response)))); 105 base::MakeUnique<StreamReaderJobDelegateImpl>(std::move(response)));
106 } else { 106 } else {
107 callback_.Run(nullptr); 107 callback_.Run(nullptr);
108 } 108 }
109 } 109 }
110 110
111 std::unique_ptr<AwContentsIoThreadClient> io_thread_client_; 111 std::unique_ptr<AwContentsIoThreadClient> io_thread_client_;
112 Callback callback_; 112 Callback callback_;
113 base::WeakPtrFactory<ShouldInterceptRequestAdaptor> weak_factory_; 113 base::WeakPtrFactory<ShouldInterceptRequestAdaptor> weak_factory_;
114 114
115 DISALLOW_COPY_AND_ASSIGN(ShouldInterceptRequestAdaptor); 115 DISALLOW_COPY_AND_ASSIGN(ShouldInterceptRequestAdaptor);
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 GURL referrer(request->referrer()); 153 GURL referrer(request->referrer());
154 if (referrer.is_valid() && 154 if (referrer.is_valid() &&
155 (!request->is_pending() || request->is_redirecting())) { 155 (!request->is_pending() || request->is_redirecting())) {
156 request->SetExtraRequestHeaderByName(net::HttpRequestHeaders::kReferer, 156 request->SetExtraRequestHeaderByName(net::HttpRequestHeaders::kReferer,
157 referrer.spec(), true); 157 referrer.spec(), true);
158 } 158 }
159 request->SetUserData(kRequestAlreadyHasJobDataKey, 159 request->SetUserData(kRequestAlreadyHasJobDataKey,
160 new base::SupportsUserData::Data()); 160 new base::SupportsUserData::Data());
161 return new AndroidStreamReaderURLRequestJob( 161 return new AndroidStreamReaderURLRequestJob(
162 request, network_delegate, 162 request, network_delegate,
163 base::WrapUnique( 163 base::MakeUnique<ShouldInterceptRequestAdaptor>(
164 new ShouldInterceptRequestAdaptor(std::move(io_thread_client))), 164 std::move(io_thread_client)),
165 true); 165 true);
166 } 166 }
167 167
168 } // namespace android_webview 168 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698