Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2711)

Unified Diff: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc

Issue 2258823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
diff --git a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
index da4c3b966b0ffb804408eae6abb889372b6f7af1..5f1eaa1ac318c8f3ed45d0f8d756d7425dc9eec8 100644
--- a/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
+++ b/android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc
@@ -80,7 +80,7 @@ class StreamReaderDelegate :
std::unique_ptr<InputStream> OpenInputStream(JNIEnv* env,
const GURL& url) override {
- return base::WrapUnique(new NotImplInputStream());
+ return base::MakeUnique<NotImplInputStream>();
}
void OnInputStreamOpenFailed(net::URLRequest* request,
@@ -211,7 +211,7 @@ class AndroidStreamReaderURLRequestJobTest : public Test {
void SetUpTestJob(std::unique_ptr<InputStreamReader> stream_reader) {
SetUpTestJob(std::move(stream_reader),
- base::WrapUnique(new StreamReaderDelegate()));
+ base::MakeUnique<StreamReaderDelegate>());
}
void SetUpTestJob(std::unique_ptr<InputStreamReader> stream_reader,
@@ -263,7 +263,7 @@ TEST_F(AndroidStreamReaderURLRequestJobTest, ReadEmptyStream) {
}
TEST_F(AndroidStreamReaderURLRequestJobTest, ReadWithNullStream) {
- SetUpTestJob(nullptr, base::WrapUnique(new NullStreamReaderDelegate()));
+ SetUpTestJob(nullptr, base::MakeUnique<NullStreamReaderDelegate>());
req_->Start();
// The TestDelegate will quit the message loop on request completion.
@@ -279,8 +279,7 @@ TEST_F(AndroidStreamReaderURLRequestJobTest, ReadWithNullStream) {
}
TEST_F(AndroidStreamReaderURLRequestJobTest, ModifyHeadersAndStatus) {
- SetUpTestJob(nullptr,
- base::WrapUnique(new HeaderAlteringStreamReaderDelegate()));
+ SetUpTestJob(nullptr, base::MakeUnique<HeaderAlteringStreamReaderDelegate>());
req_->Start();
// The TestDelegate will quit the message loop on request completion.

Powered by Google App Engine
This is Rietveld 408576698