Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

chrome/browser/permissions/permission_request.h

Index: chrome/browser/permissions/permission_request.h
diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h
index 98453d73d5da81dd74329a3781bc296c8899a67c..628f053bae3513ade9e71fe5162fc6777b667c0b 100644
--- a/chrome/browser/permissions/permission_request.h
+++ b/chrome/browser/permissions/permission_request.h
@@ -5,6 +5,7 @@
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_
 
+#include "base/macros.h"
 #include "base/strings/string16.h"
 #include "content/public/browser/permission_type.h"
 #include "url/gurl.h"
@@ -58,6 +59,7 @@ enum class PermissionRequestGestureType {
 // requests, or depending on the situation, not shown at all.
 class PermissionRequest {
  public:
+  PermissionRequest();
   virtual ~PermissionRequest() {}
 
   // Returns a vector icon id if the icon should be drawn as a vector
@@ -94,6 +96,9 @@ class PermissionRequest {
   // eventually be called on every request which is not unregistered.
   virtual void RequestFinished() = 0;
 
+  // True if a persistence toggle should be shown in the UI for this request.
+  virtual bool ShouldShowPersistenceToggle() const;
+
   // Used to record UMA metrics for permission requests.
   virtual PermissionRequestType GetPermissionRequestType() const;
 
@@ -101,6 +106,17 @@ class PermissionRequest {
   // To keep things simple this metric is only recorded for the most popular
   // request types.
   virtual PermissionRequestGestureType GetGestureType() const;
+
+  void set_persist(bool persist) { persist_ = persist; }
+
+ protected:
+  bool persist() const { return persist_; }
+
+ private:
+  // Whether or not the response for this prompt should be persisted.
+  bool persist_;

[Sergey Ulanov, 2016/08/19 17:11:53]

PermissionRequest is an interface and style guide doesn't allow to have any
state stored in an interface, see
https://google.github.io/styleguide/cppguide.html#Interfaces
Make set_persist() pure virtual?

[dominickn, 2016/08/20 01:19:24]

PermissionRequest doesn't actually satisfy the conditions for an interface: it
doesn't have only public pure virtual methods (see GetPermissionRequestType(),
GetGestureType(), and GetVectorIconId(), all of which have definitions in
permission_request.cc). So I don't think it's banned from having state. :)

Additionally, PermissionRequest has many subclasses (e.g. for protocol handling,
automatic downloads); most of which we don't want to enable optional persistence
on. However, for web API permissions, we know that confusion regarding how long
a decision is persisted for may be a factor in users just ignoring or dismissing
prompts. Considering all of that, having the persist state in the base class and
default-constructing it to true seemed to be the best way to implement this
given the current architecture.

The other option I was considering was changing the signature of
PermissionGranted() and PermissionDenied to take a boolean persist argument, but
again, that would require changing all the other subclasses where we don't want
to have optional persistence.

+
+  DISALLOW_COPY_AND_ASSIGN(PermissionRequest);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_