Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms.

chrome/browser/permissions/permission_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_
 
+#include "base/macros.h"
 #include "base/strings/string16.h"
 #include "content/public/browser/permission_type.h"
 #include "url/gurl.h"
 
 namespace gfx {
 enum class VectorIconId;
 }
 
 // Used for UMA to record the types of permission prompts shown.
 // This corresponds to the PermissionRequestType enum in
@@ skipping 33 matching lines @@
 // Describes the interface a feature making permission requests should
 // implement. A class of this type is registered with the permission request
 // manager to receive updates about the result of the permissions request
 // from the bubble or infobar. It should live until it is unregistered or until
 // RequestFinished is called.
 // Note that no particular guarantees are made about what exact UI surface
 // is presented to the user. The delegate may be coalesced with other bubble
 // requests, or depending on the situation, not shown at all.
 class PermissionRequest {
  public:
+  PermissionRequest();
   virtual ~PermissionRequest() {}
 
   // Returns a vector icon id if the icon should be drawn as a vector
   // resource. Otherwise, returns VECTOR_ICON_NONE.
   virtual gfx::VectorIconId GetVectorIconId() const;
 
   // The icon to use next to the message text fragment in the permission bubble.
   // Must be a valid icon of size 18x18.
   virtual int GetIconId() const = 0;
 
@@ skipping 16 matching lines @@
   // corresponds to a denial, but is segregated in case the context needs to
   // be able to distinguish between an active refusal or an implicit refusal.
   virtual void Cancelled() = 0;
 
   // The UI this request was associated with was answered by the user.
   // It is safe for the request to be deleted at this point -- it will receive
   // no further message from the permission request system. This method will
   // eventually be called on every request which is not unregistered.
   virtual void RequestFinished() = 0;
 
+  // True if a persistence toggle should be shown in the UI for this request.
+  virtual bool ShouldShowPersistenceToggle() const;
+
   // Used to record UMA metrics for permission requests.
   virtual PermissionRequestType GetPermissionRequestType() const;
 
   // Used to record UMA for whether requests are associated with a user gesture.
   // To keep things simple this metric is only recorded for the most popular
   // request types.
   virtual PermissionRequestGestureType GetGestureType() const;
+
+  void set_persist(bool persist) { persist_ = persist; }
+
+ protected:
+  bool persist() const { return persist_; }
+
+ private:
+  // Whether or not the response for this prompt should be persisted.
+  bool persist_;

[Sergey Ulanov, 2016/08/19 17:11:53]

PermissionRequest is an interface and style guide doesn't allow to have any
state stored in an interface, see
https://google.github.io/styleguide/cppguide.html#Interfaces
Make set_persist() pure virtual?

[dominickn, 2016/08/20 01:19:24]

PermissionRequest doesn't actually satisfy the conditions for an interface: it
doesn't have only public pure virtual methods (see GetPermissionRequestType(),
GetGestureType(), and GetVectorIconId(), all of which have definitions in
permission_request.cc). So I don't think it's banned from having state. :)

Additionally, PermissionRequest has many subclasses (e.g. for protocol handling,
automatic downloads); most of which we don't want to enable optional persistence
on. However, for web API permissions, we know that confusion regarding how long
a decision is persisted for may be a factor in users just ignoring or dismissing
prompts. Considering all of that, having the persist state in the base class and
default-constructing it to true seemed to be the best way to implement this
given the current architecture.

The other option I was considering was changing the signature of
PermissionGranted() and PermissionDenied to take a boolean persist argument, but
again, that would require changing all the other subclasses where we don't want
to have optional persistence.

+
+  DISALLOW_COPY_AND_ASSIGN(PermissionRequest);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_REQUEST_H_