Don't treat minimized windows as lower priority in MRU list (for Alt+Tab

Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org

Committed: https://crrev.com/ab7c63593c0d306dfd5ed1cdfb35d3b6b902e695
Cr-Commit-Position: refs/heads/master@{#415316}

[Evan Stade, 2016-08-18 00:57:43]

estade@chromium.org changed reviewers:
+ varkha@chromium.org

[Evan Stade, 2016-08-23 20:37:52]

ping

[varkha, 2016-08-23 22:11:58]

Tried this with overview mode and it works as expected. Thanks and lgtm!

[Evan Stade, 2016-08-24 01:24:11]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:25:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 02:10:59]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-08-26 15:00:24]

Description was changed from

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab
etc.)

BUG=635762
==========

to

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab
etc.)

BUG=635762
TBR=derat@chromium.org
==========

[Evan Stade, 2016-08-26 15:00:24]

estade@chromium.org changed reviewers:
+ derat@chromium.org

[Evan Stade, 2016-08-26 15:02:49]

had to make some changes for test failures. Updated the expectations of one test
(which is also mirrored for mus, so +derat tbr for that), and made a change to
overview to ignore window bounds changes during initialization. The bug was that
un-minimizing a window would change its bounds, which made the window grid
update other windows' bounds when those other windows had yet to be initialized
for overview.

I also switched to the use of ScopedObserver not to fix a bug but to simplify
the code a little.

[Evan Stade, 2016-08-26 15:02:56]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 15:03:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-08-26 15:29:38]

On 2016/08/26 15:02:49, Evan Stade (ooo wed-thurs) wrote:
> had to make some changes for test failures. Updated the expectations of one
test
> (which is also mirrored for mus, so +derat tbr for that), and made a change to
> overview to ignore window bounds changes during initialization. The bug was
that
> un-minimizing a window would change its bounds, which made the window grid
> update other windows' bounds when those other windows had yet to be
initialized
> for overview.
> 
> I also switched to the use of ScopedObserver not to fix a bug but to simplify
> the code a little.

This affects overview mode order as well, correct? If so, can you please update
the description?

[commit-bot: I haz the power, 2016-08-26 15:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 15:35:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-08-26 16:07:27]

Description was changed from

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab
etc.)

BUG=635762
TBR=derat@chromium.org
==========

to

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org
==========

[Daniel Erat, 2016-08-26 17:19:46]

lgtm

[Evan Stade, 2016-08-26 17:46:16]

On 2016/08/26 15:29:38, varkha wrote:
> On 2016/08/26 15:02:49, Evan Stade (ooo wed-thurs) wrote:
> > had to make some changes for test failures. Updated the expectations of one
> test
> > (which is also mirrored for mus, so +derat tbr for that), and made a change
to
> > overview to ignore window bounds changes during initialization. The bug was
> that
> > un-minimizing a window would change its bounds, which made the window grid
> > update other windows' bounds when those other windows had yet to be
> initialized
> > for overview.
> > 
> > I also switched to the use of ScopedObserver not to fix a bug but to
simplify
> > the code a little.
> 
> This affects overview mode order as well, correct? If so, can you please
update
> the description?

updated the description. Patch still lgty?

[Evan Stade, 2016-08-27 01:20:07]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:20:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:35:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2016-08-27 05:06:41]

On 2016/08/26 17:46:16, Evan Stade (ooo wed-thurs) wrote:
> On 2016/08/26 15:29:38, varkha wrote:
> > On 2016/08/26 15:02:49, Evan Stade (ooo wed-thurs) wrote:
> > > had to make some changes for test failures. Updated the expectations of
one
> > test
> > > (which is also mirrored for mus, so +derat tbr for that), and made a
change
> to
> > > overview to ignore window bounds changes during initialization. The bug
was
> > that
> > > un-minimizing a window would change its bounds, which made the window grid
> > > update other windows' bounds when those other windows had yet to be
> > initialized
> > > for overview.
> > > 
> > > I also switched to the use of ScopedObserver not to fix a bug but to
> simplify
> > > the code a little.
> > 
> > This affects overview mode order as well, correct? If so, can you please
> update
> > the description?
> 
> updated the description. Patch still lgty?

Still lgtm. Just need to fix mus version of the test.

[Evan Stade, 2016-08-29 17:02:29]

In fixing the mash version of the test, I found that mash seems to behave
differently. PTAL differences between mash and ash unit test.

[Evan Stade, 2016-08-29 17:02:34]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-08-29 17:02:49]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 17:15:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 18:00:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:00:09]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-08-29 19:00:31]

On 2016/08/29 17:02:29, Evan Stade (ooo wed-thurs) wrote:
> In fixing the mash version of the test, I found that mash seems to behave
> differently. PTAL differences between mash and ash unit test.

Still lgtm (not an owner though in ash/mus/wm).

[Evan Stade, 2016-08-30 16:22:35]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-08-30 16:22:35]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2258703002/#ps60001
(title: "fix mash")

[commit-bot: I haz the power, 2016-08-30 16:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:27:08]

Description was changed from

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org
==========

to

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 16:27:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 16:30:02]

Description was changed from

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org
==========

to

==========
Don't treat minimized windows as lower priority in MRU list (for Alt+Tab,
Overview, etc.)

BUG=635762
TBR=derat@chromium.org

Committed: https://crrev.com/ab7c63593c0d306dfd5ed1cdfb35d3b6b902e695
Cr-Commit-Position: refs/heads/master@{#415316}
==========

[commit-bot: I haz the power, 2016-08-30 16:30:03]

Patchset 4 (id:??) landed as
https://crrev.com/ab7c63593c0d306dfd5ed1cdfb35d3b6b902e695
Cr-Commit-Position: refs/heads/master@{#415316}