Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2170)

Unified Diff: ash/mus/wm/mru_window_tracker_unittest.cc

Issue 2258703002: Don't treat minimized windows as lower priority in MRU list (for Alt+Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm/overview/window_grid.cc ('k') | ash/wm/mru_window_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/mus/wm/mru_window_tracker_unittest.cc
diff --git a/ash/mus/wm/mru_window_tracker_unittest.cc b/ash/mus/wm/mru_window_tracker_unittest.cc
index b10efceaa774da76ae637ffd44e096888605b96f..4f443359df5f3f6463eedc0b4b1f9ef419bf735e 100644
--- a/ash/mus/wm/mru_window_tracker_unittest.cc
+++ b/ash/mus/wm/mru_window_tracker_unittest.cc
@@ -46,8 +46,7 @@ TEST_F(MruWindowTrackerTest, Basic) {
EXPECT_EQ(w3, window_list[2]);
}
-// Test that minimized windows are considered least recently used (but kept in
-// correct relative order).
+// Test that minimized windows are not treated specially.
TEST_F(MruWindowTrackerTest, MinimizedWindowsAreLru) {
WmWindow* w1 = CreateTestWindow();
WmWindow* w2 = CreateTestWindow();
@@ -66,15 +65,13 @@ TEST_F(MruWindowTrackerTest, MinimizedWindowsAreLru) {
w4->GetWindowState()->Minimize();
w5->GetWindowState()->Minimize();
- // Expect the relative order of minimized windows to remain the same, but all
- // minimized windows to be at the end of the list.
WmWindow::Windows window_list = mru_window_tracker()->BuildMruWindowList();
- EXPECT_EQ(w2, window_list[0]);
- EXPECT_EQ(w3, window_list[1]);
- EXPECT_EQ(w6, window_list[2]);
- EXPECT_EQ(w1, window_list[3]);
- EXPECT_EQ(w4, window_list[4]);
- EXPECT_EQ(w5, window_list[5]);
+ EXPECT_EQ(w1, window_list[0]);
+ EXPECT_EQ(w2, window_list[1]);
+ EXPECT_EQ(w3, window_list[2]);
+ EXPECT_EQ(w4, window_list[3]);
+ EXPECT_EQ(w5, window_list[4]);
+ EXPECT_EQ(w6, window_list[5]);
}
// Tests that windows being dragged are only in the WindowList once.
« no previous file with comments | « ash/common/wm/overview/window_grid.cc ('k') | ash/wm/mru_window_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698