Reimplement AllocateNearTo for 64bit.

Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/07bf777cebc18782eb83b2a5eda89110d9e58274
Cr-Commit-Position: refs/heads/master@{#413344}

[forshaw, 2016-08-17 19:04:52]

Description was changed from

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
==========

to

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Will Harris, 2016-08-17 19:17:58]

Description was changed from

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Will Harris, 2016-08-17 19:17:58]

wfh@chromium.org changed reviewers:
+ wfh@chromium.org

[elawrence, 2016-08-17 21:13:47]

This fix is effective on the machine exhibiting bug #604149.

[forshaw, 2016-08-18 12:52:24]

PTAL

[Will Harris, 2016-08-18 17:42:22]

https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
File sandbox/win/src/sandbox_nt_util_unittest.cc (right):

https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
sandbox/win/src/sandbox_nt_util_unittest.cc:167: // Test nearest allocator, only
do this for 64 bit.
all these tests are ifdefed for 64-bit, can some run on 32-bit?

[forshaw, 2016-08-18 18:02:21]

On 2016/08/18 17:42:22, Will Harris wrote:
>
https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
> File sandbox/win/src/sandbox_nt_util_unittest.cc (right):
> 
>
https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
> sandbox/win/src/sandbox_nt_util_unittest.cc:167: // Test nearest allocator,
only
> do this for 64 bit.
> all these tests are ifdefed for 64-bit, can some run on 32-bit?

We could do some tests on 32-bit but effectively you can allocate anywhere in
memory for 32bit afaik so you don't need any elaborate testing regime. That said
the code isn't trivial on 32bit but I'm not desperate to change it.

[Will Harris, 2016-08-19 16:39:52]

lgtm % nits

https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
File sandbox/win/src/sandbox_nt_util.cc (right):

https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
sandbox/win/src/sandbox_nt_util.cc:26: inline char* AlignToBoundary(void* ptr,
size_t increment) {
can you add some brief function comments on both of these functions?

https://codereview.chromium.org/2258583002/diff/20001/sandbox/win/src/sandbox...
sandbox/win/src/sandbox_nt_util.cc:28: DWORD_PTR ptr_int =
reinterpret_cast<DWORD_PTR>(ptr);
can you use uintptr_t here unless you are directly passing the result to a
windows API?

[forshaw, 2016-08-20 17:15:16]

The CQ bit was checked by forshaw@chromium.org

[forshaw, 2016-08-20 17:15:17]

The patchset sent to the CQ was uploaded after l-g-t-m from wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2258583002/#ps40001
(title: "Better comments and used standard types")

[commit-bot: I haz the power, 2016-08-20 17:15:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 18:26:02]

Description was changed from

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-08-20 18:26:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-20 18:27:23]

Description was changed from

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Reimplement AllocateNearTo for 64bit.
This CL reimplements AllocateNearTo on 64bit so that it searches for a
free memory range rather than the naive brute force approach we used
before.

BUG=604149
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/07bf777cebc18782eb83b2a5eda89110d9e58274
Cr-Commit-Position: refs/heads/master@{#413344}
==========

[commit-bot: I haz the power, 2016-08-20 18:27:23]

Patchset 3 (id:??) landed as
https://crrev.com/07bf777cebc18782eb83b2a5eda89110d9e58274
Cr-Commit-Position: refs/heads/master@{#413344}