Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2258553003: [Downloads] Handle externally deleted items (Closed)

Created:
4 years, 4 months ago by Theresa
Modified:
4 years, 4 months ago
Reviewers:
qinmin, gone
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Handle externally deleted items * If the file associated with a download has been deleted through an external user action, it is styled differenting in the download manager UI. * Don't allow externally deleted files to be shared. * Refresh list of externally deleted files after download items are removed through the browser UI. BUG=616324 Committed: https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd Cr-Commit-Position: refs/heads/master@{#412682}

Patch Set 1 #

Total comments: 13

Patch Set 2 : dfalcantara@ review #

Messages

Total messages: 20 (13 generated)
Theresa
ptal https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java File chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java (right): https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java#newcode271 chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:271: for (int i = 0; i < selectedItems.size(); ...
4 years, 4 months ago (2016-08-17 18:38:13 UTC) #2
gone
lgtm, but run this by Min. https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java (right): https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java#newcode96 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:96: * from the ...
4 years, 4 months ago (2016-08-17 20:59:25 UTC) #7
Theresa
+qinmin@ for DownloadManagerService changes https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java (right): https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java#newcode96 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:96: * from the file system ...
4 years, 4 months ago (2016-08-17 21:55:43 UTC) #11
qinmin
lgtm
4 years, 4 months ago (2016-08-17 23:01:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258553003/20001
4 years, 4 months ago (2016-08-17 23:03:32 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 23:09:02 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 23:19:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd
Cr-Commit-Position: refs/heads/master@{#412682}

Powered by Google App Engine
This is Rietveld 408576698