[Downloads] Handle externally deleted items

[Downloads] Handle externally deleted items

* If the file associated with a download has been
  deleted through an external user action, it is styled
  differenting in the download manager UI.

* Don't allow externally deleted files to be shared.

* Refresh list of externally deleted files after
  download items are removed through the browser UI.

BUG=616324
Committed: https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd
Cr-Commit-Position: refs/heads/master@{#412682}

[Theresa, 2016-08-17 18:38:12]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-08-17 18:38:13]

ptal

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:271:
for (int i = 0; i < selectedItems.size(); i++) {
Avoiding the foreach loop because Java allocates an iterator(). See tedchoc@'s
comments here:
https://codereview.chromium.org/2159533002/diff/120001/chrome/android/java/sr...

[Theresa, 2016-08-17 18:38:16]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:38:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:22:38]

Dry run: This issue passed the CQ dry run.

[gone, 2016-08-17 20:59:25]

lgtm, but run this by Min.

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:96:
* from the file system through a means other than the browser download ui.
line up from with Whether?

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:104:
* through a means other than the browser download ui.
through under Whether?

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:183:
// Return early if the item's style doesn't need to be updated.
Given how much stuff is going on below, I wonder if it makes more sense to:
1) Pull out the below code into a private function
2) Avoid the early return and just call the other function conditionally

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
(right):

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:74:
* @return Whether the file associated with this item has been removed through an
external
nit: indent alignment

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:201:
public void onPostExecute(Void result) {
Should you just use org.chromium.base.Callback or Runnable instead?  Avoids the
extra interface declaration.

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://chromiumcodereview.appspot.com/2258553003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:88:
private AtomicInteger mNumberOfFilesBeingDeleted = new AtomicInteger();
private final?

[Theresa, 2016-08-17 21:53:29]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:53:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-08-17 21:55:42]

twellington@chromium.org changed reviewers:
+ qinmin@chromium.org

[Theresa, 2016-08-17 21:55:43]

+qinmin@ for DownloadManagerService changes

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
(right):

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:96:
* from the file system through a means other than the browser download ui.
On 2016/08/17 20:59:24, dfalcantara wrote:
> line up from with Whether?

Done.

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java:104:
* through a means other than the browser download ui.
On 2016/08/17 20:59:24, dfalcantara wrote:
> through under Whether?

Done.

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
(right):

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java:183:
// Return early if the item's style doesn't need to be updated.
On 2016/08/17 20:59:24, dfalcantara wrote:
> Given how much stuff is going on below, I wonder if it makes more sense to:
> 1) Pull out the below code into a private function
> 2) Avoid the early return and just call the other function conditionally

Done.

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java
(right):

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:74:
* @return Whether the file associated with this item has been removed through an
external
On 2016/08/17 20:59:24, dfalcantara wrote:
> nit: indent alignment

Done.

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java:201:
public void onPostExecute(Void result) {
On 2016/08/17 20:59:24, dfalcantara wrote:
> Should you just use org.chromium.base.Callback or Runnable instead?  Avoids
the
> extra interface declaration.

Switched it to org.chromium.base.Callback<Boolean>

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://codereview.chromium.org/2258553003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:88:
private AtomicInteger mNumberOfFilesBeingDeleted = new AtomicInteger();
On 2016/08/17 20:59:24, dfalcantara wrote:
> private final?

Done.

[commit-bot: I haz the power, 2016-08-17 22:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:37:18]

Dry run: This issue passed the CQ dry run.

[qinmin, 2016-08-17 23:01:54]

lgtm

[Theresa, 2016-08-17 23:03:03]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-08-17 23:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2258553003/#ps20001
(title: "dfalcantara@ review")

[commit-bot: I haz the power, 2016-08-17 23:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:09:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 23:19:44]

Description was changed from

==========
[Downloads] Handle externally deleted items

* If the file associated with a download has been
  deleted through an external user action, it is styled
  differenting in the download manager UI.

* Don't allow externally deleted files to be shared.

* Refresh list of externally deleted files after
  download items are removed through the browser UI.

BUG=616324
==========

to

==========
[Downloads] Handle externally deleted items

* If the file associated with a download has been
  deleted through an external user action, it is styled
  differenting in the download manager UI.

* Don't allow externally deleted files to be shared.

* Refresh list of externally deleted files after
  download items are removed through the browser UI.

BUG=616324

Committed: https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd
Cr-Commit-Position: refs/heads/master@{#412682}
==========

[commit-bot: I haz the power, 2016-08-17 23:19:45]

Patchset 2 (id:??) landed as
https://crrev.com/5dd7646463b152ca4af253e5cfb374676238cbfd
Cr-Commit-Position: refs/heads/master@{#412682}