third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & fix mistake Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h ('K') | « third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp ('k') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 1c356515a000fbe6f1ef14f2e71e5212e912f078..2ebb9a1392f15403558f000055755bdadf97c985 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -829,8 +829,7 @@ static bool overflowDefinesAutomaticScrollbar(EOverflow overflow)

// handled externally in the RLC.

static bool canHaveOverflowScrollbars(const LayoutBox& box)

{

- bool rootLayerScrolls = box.document().settings() && box.document().settings()->rootLayerScrolls();

- return (rootLayerScrolls || !box.isLayoutView()) && box.document().viewportDefiningElement() != box.node();

+ return (RuntimeEnabledFeatures::rootLayerScrollingEnabled() || !box.isLayoutView()) && box.document().viewportDefiningElement() != box.node();

}

void PaintLayerScrollableArea::updateAfterStyleChange(const ComputedStyle* oldStyle)