third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp - Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & fix mistake Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Settings.in ('k') | third_party/WebKit/Source/core/layout/LayoutView.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

index f4f03f0d8391e071a917159bc1499b6b5d7abc7b..faf9662502996bb0eb7be03823c8b0d087dacc57 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

@@ -565,8 +565,7 @@ static void write(TextStream& ts, PaintLayer& layer,

IntRect adjustedBackgroundClipRect = pixelSnappedIntRect(backgroundClipRect);

IntRect adjustedClipRect = pixelSnappedIntRect(clipRect);

- Settings* settings = layer.layoutObject()->document().settings();

- bool reportFrameScrollInfo = layer.layoutObject()->isLayoutView() && settings && !settings->rootLayerScrolls();

+ bool reportFrameScrollInfo = layer.layoutObject()->isLayoutView() && !RuntimeEnabledFeatures::rootLayerScrollingEnabled();

if (reportFrameScrollInfo) {

LayoutView* layoutView = toLayoutView(layer.layoutObject());