third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp - Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Issue 2258523006: Convert Settings::rootLayerScrolls to RuntimeEnabledFeatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/FrameViewTest.cpp ('K') | « third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp ('k') | third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

index 64fee79dc7be81d06b44ab4616e5098999747cc2..0c7f87c2431bff3624268c134932f5d5152bc275 100644

--- a/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

@@ -128,7 +128,7 @@ PaintInvalidationReason BoxPaintInvalidator::computePaintInvalidationReason()

// and clipping is done by compositor()->m_containerLayer. Also the scrollbars

// are always composited. There are no other box decoration on the LayoutView thus

// we can safely exit here.

- if (layoutView.usesCompositing() && (!layoutView.document().settings() || !layoutView.document().settings()->rootLayerScrolls()))

+ if (layoutView.usesCompositing() && !RuntimeEnabledFeatures::rootLayerScrollingEnabled())

return reason;

}