Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 2258523004: Remove an unneeded variable in PDF's ScopedUnsupportedFeature. (Closed)

Created:
1 year, 3 months ago by Lei Zhang
Modified:
1 year, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an unneeded variable in PDF's ScopedUnsupportedFeature. Committed: https://crrev.com/27c7931f5d3fd1e28e24001f488a6a25731c3f65 Cr-Commit-Position: refs/heads/master@{#412951}

Patch Set 1 #

Patch Set 2 : const #

Messages

Total messages: 13 (7 generated)
Lei Zhang
1 year, 3 months ago (2016-08-18 19:22:56 UTC) #4
tommycli
lgtm. Intent is to temporarily replace the global engine with a temporary engine right?
1 year, 3 months ago (2016-08-18 19:50:49 UTC) #5
Lei Zhang
On 2016/08/18 19:50:49, tommycli wrote: > lgtm. Intent is to temporarily replace the global engine ...
1 year, 3 months ago (2016-08-18 20:13:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258523004/20001
1 year, 3 months ago (2016-08-18 21:21:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 3 months ago (2016-08-18 22:10:06 UTC) #11
commit-bot: I haz the power
1 year, 3 months ago (2016-08-18 22:14:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27c7931f5d3fd1e28e24001f488a6a25731c3f65
Cr-Commit-Position: refs/heads/master@{#412951}

Powered by Google App Engine
This is Rietveld efc10ee0f