Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 2258513003: Revert of Migrate WebVR Cardboard implementation to GVR (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gvr_third_party
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate WebVR Cardboard implementation to GVR (patchset #20 id:380001 of https://codereview.chromium.org/2219203002/ ) Reason for revert: Android build failure on cronet: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20MIPS%20Builder/builds/4131 /b/build/slave/Android_Cronet_MIPS_Builder/build/src/buildtools/linux64/gn gen //out/Release --check -> returned 1 ERROR at //third_party/gvr-android-sdk/BUILD.gn:27:1: Empty sources for copy command. copy("libgvr_shared_library") { ^------------------------------ You have to specify at least one file to copy in the "sources". See //device/vr/BUILD.gn:47:7: which caused the file to be included. "//third_party/gvr-android-sdk:libgvr", ^------------------------------------- GN gen failed: 1 step returned non-zero exit code: 1 Also suspect but have not confirmed causing these two build failures: https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/7419 https://build.chromium.org/p/chromium.android/builders/Android%20x64%20Builder%20%28dbg%29/builds/7722 Original issue's description: > Migrate WebVR Cardboard implementation to GVR > > BUG=389343 > > Committed: https://crrev.com/267d5f909f25543d2351cc506626b5d5c08461c3 > Cr-Commit-Position: refs/heads/master@{#412710} TBR=dtrainor@chromium.org,girard@chromium.org,bshe@chromium.org,mthiesse@chromium.org,klausw@google.com,sievers@chromium.org,bajones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=389343 Committed: https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd Cr-Commit-Position: refs/heads/master@{#412724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -498 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content.gyp View 1 chunk +10 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M device/BUILD.gn View 3 chunks +5 lines, -13 lines 0 comments Download
M device/vr/BUILD.gn View 4 chunks +7 lines, -19 lines 0 comments Download
M device/vr/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
A device/vr/android/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download
A device/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +34 lines, -0 lines 0 comments Download
A device/vr/android/cardboard/cardboard_vr_device.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A device/vr/android/cardboard/cardboard_vr_device_provider.h View 1 chunk +33 lines, -0 lines 0 comments Download
A device/vr/android/cardboard/cardboard_vr_device_provider.cc View 1 chunk +27 lines, -0 lines 0 comments Download
D device/vr/android/gvr/gvr_api_manager.h View 1 chunk +0 lines, -44 lines 0 comments Download
D device/vr/android/gvr/gvr_api_manager.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D device/vr/android/gvr/gvr_device.h View 1 chunk +0 lines, -35 lines 0 comments Download
D device/vr/android/gvr/gvr_device.cc View 1 chunk +0 lines, -136 lines 0 comments Download
D device/vr/android/gvr/gvr_device_provider.h View 1 chunk +0 lines, -41 lines 0 comments Download
D device/vr/android/gvr/gvr_device_provider.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A device/vr/android/java/src/org/chromium/device/vr/CardboardVRDevice.java View 1 chunk +88 lines, -0 lines 0 comments Download
D device/vr/android/java/src/org/chromium/device/vr/GvrDeviceProvider.java View 1 chunk +0 lines, -56 lines 0 comments Download
A device/vr/android/vr_jni_registrar.h View 1 chunk +24 lines, -0 lines 0 comments Download
A device/vr/android/vr_jni_registrar.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M device/vr/vr_device_manager.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/gvr-android-sdk/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/gvr-android-sdk/proguard/base.flags View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
boliu
Created Revert of Migrate WebVR Cardboard implementation to GVR
4 years, 4 months ago (2016-08-18 02:21:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258513003/1
4 years, 4 months ago (2016-08-18 02:22:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 02:23:29 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 02:25:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60fb40258dc3548735720b48a5a8cfad8c11ecbd
Cr-Commit-Position: refs/heads/master@{#412724}

Powered by Google App Engine
This is Rietveld 408576698