Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Issue 2258123002: [parser] Refactor parser and preparser traits (Closed)

Created:
4 years, 4 months ago by nickie
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@nickie-2264483003-ord-traits
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

This patch continues the refactoring of the traits objects, used by the parser and the preparser, so that they contain the same set of methods, with the same signatures. It mainly flags some traits methods as const. It also contains a small cosmetic change in the definition of CHECK_OK. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/8133ab4c1a7405b52f5146c22bbacaabf9a22ae1 Cr-Commit-Position: refs/heads/master@{#38767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -54 lines) Patch
M src/parsing/parser.h View 4 chunks +24 lines, -21 lines 0 comments Download
M src/parsing/parser.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 6 chunks +8 lines, -8 lines 0 comments Download
M src/parsing/preparser.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
nickie
4 years, 4 months ago (2016-08-19 13:22:03 UTC) #1
adamk
lgtm
4 years, 4 months ago (2016-08-19 18:01:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258123002/1
4 years, 4 months ago (2016-08-20 14:12:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 14:36:07 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 14:36:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8133ab4c1a7405b52f5146c22bbacaabf9a22ae1
Cr-Commit-Position: refs/heads/master@{#38767}

Powered by Google App Engine
This is Rietveld 408576698