Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Issue 2264483003: [parser] Reorder traits methods (Closed)

Created:
4 years, 4 months ago by nickie
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Reorder traits methods This patch simply reorders the elements of classes ParserTraits and PreParserTraits (mainly method headers), so that in both classes the elements are defined in the same order. This is useful for easily verifying the consistency between these two classes. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/848b6278f8e52cc7a88423d9493e83fdb0866e58 Cr-Commit-Position: refs/heads/master@{#38766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes after reviewers' comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -68 lines) Patch
M src/parsing/parser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/parsing/preparser.h View 1 13 chunks +69 lines, -64 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
nickie
4 years, 4 months ago (2016-08-19 13:00:13 UTC) #1
nickie
This patch only moves methods up and down, only inside the declaration of classes ParserTraits ...
4 years, 4 months ago (2016-08-19 13:03:40 UTC) #2
adamk
lgtm % nit https://codereview.chromium.org/2264483003/diff/1/src/parsing/preparser.h File src/parsing/preparser.h (right): https://codereview.chromium.org/2264483003/diff/1/src/parsing/preparser.h#newcode989 src/parsing/preparser.h:989: V8_INLINE PreParserExpression RewriteYieldStar(PreParserExpression generator, I'd leave ...
4 years, 4 months ago (2016-08-19 17:59:58 UTC) #7
nickie
https://codereview.chromium.org/2264483003/diff/1/src/parsing/preparser.h File src/parsing/preparser.h (right): https://codereview.chromium.org/2264483003/diff/1/src/parsing/preparser.h#newcode989 src/parsing/preparser.h:989: V8_INLINE PreParserExpression RewriteYieldStar(PreParserExpression generator, On 2016/08/19 17:59:58, adamk wrote: ...
4 years, 4 months ago (2016-08-20 13:33:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264483003/20001
4 years, 4 months ago (2016-08-20 14:09:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 14:11:14 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 14:11:40 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/848b6278f8e52cc7a88423d9493e83fdb0866e58
Cr-Commit-Position: refs/heads/master@{#38766}

Powered by Google App Engine
This is Rietveld 408576698