third_party/WebKit/Source/core/html/PluginDocument.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/PluginDocument.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp ('k') | third_party/WebKit/Source/core/html/RadioNodeList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/PluginDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/PluginDocument.cpp b/third_party/WebKit/Source/core/html/PluginDocument.cpp

index 8f4f31157243e27f541b4a4fd12e3c9aea1403af..d9254c39c9fc9764198dc135c6fa4f0fd923a6f6 100644

--- a/third_party/WebKit/Source/core/html/PluginDocument.cpp

+++ b/third_party/WebKit/Source/core/html/PluginDocument.cpp

@@ -79,7 +79,7 @@ void PluginDocumentParser::createDocumentStructure()

{

// FIXME: Assert we have a loader to figure out why the original null checks

// and assert were added for the security bug in http://trac.webkit.org/changeset/87566

- ASSERT(document());

+ DCHECK(document());

RELEASE_ASSERT(document()->loader());

LocalFrame* frame = document()->frame();

@@ -154,7 +154,7 @@ void PluginDocumentParser::finish()

PluginView* PluginDocumentParser::pluginView() const

{

if (Widget* widget = toPluginDocument(document())->pluginWidget()) {

- ASSERT_WITH_SECURITY_IMPLICATION(widget->isPluginContainer());

+ SECURITY_DCHECK(widget->isPluginContainer());

return toPluginView(widget);

}

return 0;