third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp - Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

Issue 2258033002: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace ASSERT()s with DCHECK*() in core/html/*.{cpp,h}. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/MediaDocument.cpp ('k') | third_party/WebKit/Source/core/html/PluginDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

diff --git a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

index 635f4b34e1a6d6b078d86ffd4ae4353cc4132018..8842b5c90f3894c3a7bab5b65f93da5ff43ef465 100644

--- a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

+++ b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

@@ -144,7 +144,7 @@ void MediaFragmentURIParser::parseFragments()

void MediaFragmentURIParser::parseTimeFragment()

{

- ASSERT(m_timeFormat == None);

+ DCHECK_EQ(m_timeFormat, None);

if (m_fragments.isEmpty())

parseFragments();

@@ -154,8 +154,8 @@ void MediaFragmentURIParser::parseTimeFragment()

for (unsigned i = 0; i < m_fragments.size(); ++i) {

std::pair<String, String>& fragment = m_fragments[i];

- ASSERT(fragment.first.is8Bit());

- ASSERT(fragment.second.is8Bit());

+ DCHECK(fragment.first.is8Bit());

+ DCHECK(fragment.second.is8Bit());

// http://www.w3.org/2008/WebVideo/Fragments/WD-media-fragments-spec/#naming-time

// Temporal clipping is denoted by the name t, and specified as an interval with a begin

« no previous file with comments | « third_party/WebKit/Source/core/html/MediaDocument.cpp ('k') | third_party/WebKit/Source/core/html/PluginDocument.cpp » ('j') | no next file with comments »