Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2258023003: Remove first argument for shoudCreateCustomElement() (Closed)

Created:
4 years, 4 months ago by kochi
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org, kojii
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove first argument for shoudCreateCustomElement() After https://codereview.chromium.org/2252003002 (Change custom element state in documents without browsing context), the first argument (document) is not necessary for CustomElement::shouldCreateCustomElement(). This is clean-up only and no functional change. BUG=594918 Committed: https://crrev.com/1ec66e48c250406c6fff63e7d8d8cdeadd7c0995 Cr-Commit-Position: refs/heads/master@{#413096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElement.cpp View 6 chunks +8 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
dominicc (has gone to gerrit)
lgtm
4 years, 4 months ago (2016-08-19 04:55:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258023003/1
4 years, 4 months ago (2016-08-19 04:57:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276788)
4 years, 4 months ago (2016-08-19 06:47:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258023003/1
4 years, 4 months ago (2016-08-19 07:00:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 10:00:30 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 10:02:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec66e48c250406c6fff63e7d8d8cdeadd7c0995
Cr-Commit-Position: refs/heads/master@{#413096}

Powered by Google App Engine
This is Rietveld 408576698