Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp

Issue 2258023003: Remove first argument for shoudCreateCustomElement() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
index 282fa462f1cec75149c5b5725d8acbb0f682adb5..f5d1b2084259d210e062bf6553be983a8d4a5af4 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
@@ -78,15 +78,15 @@ bool CustomElement::isValidName(const AtomicString& name)
return !hyphenContainingElementNames.contains(name);
}
-bool CustomElement::shouldCreateCustomElement(Document& document, const AtomicString& localName)
+bool CustomElement::shouldCreateCustomElement(const AtomicString& localName)
{
return RuntimeEnabledFeatures::customElementsV1Enabled()
&& isValidName(localName);
}
-bool CustomElement::shouldCreateCustomElement(Document& document, const QualifiedName& tagName)
+bool CustomElement::shouldCreateCustomElement(const QualifiedName& tagName)
{
- return shouldCreateCustomElement(document, tagName.localName())
+ return shouldCreateCustomElement(tagName.localName())
&& tagName.namespaceURI() == HTMLNames::xhtmlNamespaceURI;
}
@@ -106,7 +106,7 @@ HTMLElement* CustomElement::createCustomElementSync(Document& document, const At
HTMLElement* CustomElement::createCustomElementSync(Document& document, const QualifiedName& tagName, ExceptionState& exceptionState)
{
- CHECK(shouldCreateCustomElement(document, tagName));
+ CHECK(shouldCreateCustomElement(tagName));
// To create an element:
// https://dom.spec.whatwg.org/#concept-create-element
@@ -120,7 +120,7 @@ HTMLElement* CustomElement::createCustomElementSync(Document& document, const Qu
HTMLElement* CustomElement::createCustomElementSync(Document& document, const QualifiedName& tagName)
{
- CHECK(shouldCreateCustomElement(document, tagName));
+ CHECK(shouldCreateCustomElement(tagName));
// When invoked from "create an element for a token":
// https://html.spec.whatwg.org/multipage/syntax.html#create-an-element-for-the-token
@@ -135,7 +135,7 @@ HTMLElement* CustomElement::createCustomElementSync(Document& document, const Qu
HTMLElement* CustomElement::createCustomElementAsync(Document& document, const QualifiedName& tagName)
{
- CHECK(shouldCreateCustomElement(document, tagName));
+ CHECK(shouldCreateCustomElement(tagName));
// To create an element:
// https://dom.spec.whatwg.org/#concept-create-element
@@ -149,7 +149,7 @@ HTMLElement* CustomElement::createCustomElementAsync(Document& document, const Q
HTMLElement* CustomElement::createUndefinedElement(Document& document, const QualifiedName& tagName)
{
- DCHECK(shouldCreateCustomElement(document, tagName));
+ DCHECK(shouldCreateCustomElement(tagName));
HTMLElement* element;
if (V0CustomElement::isValidName(tagName.localName()) && document.registrationContext()) {
@@ -167,7 +167,7 @@ HTMLElement* CustomElement::createUndefinedElement(Document& document, const Qua
HTMLElement* CustomElement::createFailedElement(Document& document, const QualifiedName& tagName)
{
- DCHECK(shouldCreateCustomElement(document, tagName));
+ DCHECK(shouldCreateCustomElement(tagName));
// "create an element for a token":
// https://html.spec.whatwg.org/multipage/syntax.html#create-an-element-for-the-token
« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698