Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2257923002: arc: Handle non-launchable apps. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Handle non-launchable apps. There are Android apps that can be started indirectly and which don't have launchable flag. We had no support such apps in Chrome and that caused incorrect behavior in shelf. Fix is to register such apps on creation with special flag that prevents them to appear in launcher app list and to be pinned in shelf. BUG=635536 BUG=b/30508435 TEST=Manually on device. Icon of an app (app info) appears on the shelf and cannot be pinned. No app info icon in app list. TEST=Extended unit_test TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2210143003 Cr-Commit-Position: refs/heads/master@{#411120} (cherry picked from commit 25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -19 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 5 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 14 chunks +37 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 2 chunks +16 lines, -1 line 0 comments Download
M components/arc/common/app.mojom View 2 chunks +5 lines, -3 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257923002/1
4 years, 4 months ago (2016-08-18 20:10:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 20:14:30 UTC) #6
khmel
4 years, 4 months ago (2016-08-18 20:15:02 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2259033002/ by khmel@chromium.org.

The reason for reverting is: Wrong resolve.

Powered by Google App Engine
This is Rietveld 408576698