arc: Handle non-launchable apps.

arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test

Committed: https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab
Cr-Commit-Position: refs/heads/master@{#411120}

[khmel, 2016-08-04 17:02:40]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-08-04 17:02:41]

Hi Xiyuan,

PTAL

[xiyuan, 2016-08-05 17:39:39]

lgtm

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.h (right):

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.h:232: void
OnTaskCreatedDepricated(int32_t task_id,
nit: OnTaskCreatedDepricated -> OnTaskCreatedDeprecated

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:186: VLOG(2) << "Cannot launch
not-launchable app: " << app_id << ".";
nit: not-launchable -> non-launchable to be consistent

[khmel, 2016-08-05 18:28:35]

Thanks Xiyuan for review.

+dcheng@ (components/arc/common/app.mojom)
+oshima@ (chrome/browser/ui/ash)
+elijahtaylor@ (components/arc/test/fake_app_instance)

PTAL

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_list_prefs.h (right):

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_list_prefs.h:232: void
OnTaskCreatedDepricated(int32_t task_id,
On 2016/08/05 17:39:39, xiyuan wrote:
> nit: OnTaskCreatedDepricated -> OnTaskCreatedDeprecated

Done.

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right):

https://codereview.chromium.org/2210143003/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/arc/arc_app_utils.cc:186: VLOG(2) << "Cannot launch
not-launchable app: " << app_id << ".";
On 2016/08/05 17:39:39, xiyuan wrote:
> nit: not-launchable -> non-launchable to be consistent

Done.

[khmel, 2016-08-05 19:54:26]

khmel@chromium.org changed reviewers:
+ dcheng@chromium.org, elijahtaylor@chromium.org, oshima@chromium.org

[khmel, 2016-08-05 19:54:26]

PTAL

[khmel, 2016-08-05 19:59:02]

khmel@chromium.org changed reviewers:
+ rickyz@chromium.org
- dcheng@chromium.org

[khmel, 2016-08-05 19:59:03]

+rickyz@ once dcheng is OOO for long time

[oshima, 2016-08-05 23:16:41]

lgtm

does this have to be merged to 53? If so, please file crbug so that you can
request merge.

[khmel, 2016-08-08 14:53:55]

Description was changed from

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
==========

to

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
==========

[khmel, 2016-08-08 14:55:36]

khmel@chromium.org changed reviewers:
+ lhchavez@chromium.org
- elijahtaylor@chromium.org

[khmel, 2016-08-08 14:55:37]

Luis is back and I can address changes (in component/arc/tests at least) instead
of Elijah.

PTAL.

[rickyz (no longer on Chrome), 2016-08-09 01:34:16]

mojom lgtm

[khmel, 2016-08-10 16:42:33]

Thanks Luis for idea to simplify mojo declaration.

PTAL

[khmel, 2016-08-10 16:42:36]

Thanks Luis for idea to simplify mojo declaration.

PTAL

[rickyz (no longer on Chrome), 2016-08-10 17:34:19]

mojom still lgtm, thanks

[Luis Héctor Chávez, 2016-08-10 17:48:53]

lgtm with a nit

https://codereview.chromium.org/2210143003/diff/60001/components/arc/common/a...
File components/arc/common/app.mojom (right):

https://codereview.chromium.org/2210143003/diff/60001/components/arc/common/a...
components/arc/common/app.mojom:94: [MinVersion=4] OnTaskCreated@4(int32
task_id,
FYI: I was able to add the field in the middle by adding ordinals to every
field:

[MinVersion=4] OnTaskCreated@4(int32 task_id@0,
                               string package_name@1,
                               [MinVersion=13] string? name@3,
                               string activity@2);

up to you if you want to keep this ordering or the one you preferred originally.
In any case, please add explicit ordinals to all parameters.

[khmel, 2016-08-10 18:01:00]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-10 18:01:01]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
oshima@chromium.org, lhchavez@chromium.org, rickyz@chromium.org
Link to the patchset: https://codereview.chromium.org/2210143003/#ps80001
(title: "add ordinals to mojo")

[commit-bot: I haz the power, 2016-08-10 18:01:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:26:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:26:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[khmel, 2016-08-10 19:02:59]

The CQ bit was checked by khmel@chromium.org

[khmel, 2016-08-10 19:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
lhchavez@chromium.org, rickyz@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2210143003/#ps100001
(title: "fix unit_tests due rebase and mojo param order change - trivial")

[commit-bot: I haz the power, 2016-08-10 19:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:44:06]

Description was changed from

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
==========

to

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
==========

[commit-bot: I haz the power, 2016-08-10 19:44:08]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-10 19:45:35]

Description was changed from

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test
==========

to

==========
arc: Handle non-launchable apps.

There are Android apps that can be started indirectly and which
don't have launchable flag. We had no support such apps in Chrome
and that caused incorrect behavior in shelf. Fix is to register
such apps on creation with special flag that prevents them to
appear in launcher app list and to be pinned in shelf.

BUG=635536
BUG=b/30508435
TEST=Manually on device. Icon of an app (app info) appears on the
     shelf and cannot be pinned. No app info icon in app list.
TEST=Extended unit_test

Committed: https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab
Cr-Commit-Position: refs/heads/master@{#411120}
==========

[commit-bot: I haz the power, 2016-08-10 19:45:37]

Patchset 6 (id:??) landed as
https://crrev.com/25bc1656ca1b11876bbc3a8407c13ebe6c88b7ab
Cr-Commit-Position: refs/heads/master@{#411120}