Issue 2257873004: [Chromecast] Set all video to opaque

Issue 2257873004: [Chromecast] Set all video to opaque (Closed)

Created:
4 years, 4 months ago by halliwell

Modified:
4 years, 4 months ago

Reviewers:
slan, Daniele Castagna, DaleCurtis

CC:
alokp+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[Chromecast] Set all video to opaque Our video overlay codepath was broken here; this change rejects non-opaque video frames for overlay: https://codereview.chromium.org/2162663003 BUG=639182 TEST=manual Committed: https://crrev.com/9c3ec304053760c3439f6848fd624a3a9e7e8793 Cr-Commit-Position: refs/heads/master@{#413219}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chromecast/browser/media/cast_renderer.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 11 (5 generated)

halliwell

Dale/Daniele: is it right that WMPI treats all video as non-opaque by default? It seems ...

4 years, 4 months ago (2016-08-19 03:33:29 UTC) #3

DaleCurtis

Yeah it does seem like we should flip the default, though I don't think it ...

4 years, 4 months ago (2016-08-19 16:37:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257873004/1

4 years, 4 months ago (2016-08-19 19:03:06 UTC) #7

commit-bot: I haz the power

4 years, 4 months ago (2016-08-19 19:59:19 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9c3ec304053760c3439f6848fd624a3a9e7e8793
Cr-Commit-Position: refs/heads/master@{#413219}