Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2162663003: Don't reject overlay candidates for premultiplied alpha. (Closed)

Created:
4 years, 5 months ago by Daniele Castagna
Modified:
4 years, 5 months ago
Reviewers:
reveman, halliwell, ccameron
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't reject overlay candidates for premultiplied alpha. Buffers with premultiplied alpha can be used as an overlay when drawing them doesn't need alpha blending. This CL removes the check that rejected texture quads with premul alpha when costructing overlay candidates and make stricter the blending check. BUG=b/29430506 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/611a405b6b8968fb667c7e308c1a3ac681e8a9a2 Cr-Commit-Position: refs/heads/master@{#406221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M cc/output/overlay_candidate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Daniele Castagna
4 years, 5 months ago (2016-07-19 02:33:06 UTC) #7
reveman
lgtm
4 years, 5 months ago (2016-07-19 02:35:51 UTC) #9
Daniele Castagna
ccing halliwell since this code is used on chromecast.
4 years, 5 months ago (2016-07-19 03:24:04 UTC) #10
halliwell
On 2016/07/19 03:24:04, Daniele Castagna wrote: > ccing halliwell since this code is used on ...
4 years, 5 months ago (2016-07-19 05:51:06 UTC) #13
ccameron
lgtm
4 years, 5 months ago (2016-07-19 06:00:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162663003/1
4 years, 5 months ago (2016-07-19 06:02:34 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 06:06:40 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 06:07:57 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/611a405b6b8968fb667c7e308c1a3ac681e8a9a2
Cr-Commit-Position: refs/heads/master@{#406221}

Powered by Google App Engine
This is Rietveld 408576698