Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.h

Issue 225783003: Remove ScriptState from NodeIterator, NodeFilter, NodeFilterCondition and TreeWalker (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/V8NodeFilterCondition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8NodeFilterCondition.h
diff --git a/Source/bindings/v8/V8NodeFilterCondition.h b/Source/bindings/v8/V8NodeFilterCondition.h
index abff9e364a1b79d9a72a8a031ccb843eccfc5e6d..1689c14066da335da315cd2631212675d1c8ab68 100644
--- a/Source/bindings/v8/V8NodeFilterCondition.h
+++ b/Source/bindings/v8/V8NodeFilterCondition.h
@@ -31,6 +31,7 @@
#ifndef V8NodeFilterCondition_h
#define V8NodeFilterCondition_h
+#include "bindings/v8/NewScriptState.h"
#include "bindings/v8/ScopedPersistent.h"
#include "core/dom/NodeFilterCondition.h"
#include <v8.h>
@@ -39,7 +40,7 @@
namespace WebCore {
class Node;
-class ScriptState;
+class ExceptionState;
// V8NodeFilterCondition maintains a Javascript implemented callback for
// filtering Node returned by NodeIterator/TreeWalker.
@@ -67,7 +68,7 @@ public:
virtual ~V8NodeFilterCondition();
- virtual short acceptNode(ScriptState*, Node*) const OVERRIDE;
+ virtual short acceptNode(Node*, ExceptionState&) const OVERRIDE;
private:
// As the value |filter| is maintained by V8GC, the |owner| which references
@@ -77,6 +78,7 @@ private:
static void setWeakCallback(const v8::WeakCallbackData<v8::Value, V8NodeFilterCondition>&);
+ RefPtr<NewScriptState> m_scriptState;
ScopedPersistent<v8::Value> m_filter;
};
« no previous file with comments | « no previous file | Source/bindings/v8/V8NodeFilterCondition.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698