Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: components/variations/service/variations_service_unittest.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/service/variations_service_unittest.cc
diff --git a/components/variations/service/variations_service_unittest.cc b/components/variations/service/variations_service_unittest.cc
index 6530849ab6c129381691694f85353d6fd287f923..d6293876b093a9680253a870035e89e5b9c3fe6f 100644
--- a/components/variations/service/variations_service_unittest.cc
+++ b/components/variations/service/variations_service_unittest.cc
@@ -278,7 +278,7 @@ TEST_F(VariationsServiceTest, CreateTrialsFromSeed) {
// Create a variations service.
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.SetCreateTrialsFromSeedCalledForTesting(false);
@@ -305,7 +305,7 @@ TEST_F(VariationsServiceTest, CreateTrialsFromSeedNoLastFetchTime) {
// Create a variations service
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.SetCreateTrialsFromSeedCalledForTesting(false);
@@ -332,7 +332,7 @@ TEST_F(VariationsServiceTest, CreateTrialsFromOutdatedSeed) {
// Create a variations service.
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.SetCreateTrialsFromSeedCalledForTesting(false);
@@ -356,11 +356,11 @@ TEST_F(VariationsServiceTest, GetVariationsServerURL) {
std::string value;
std::unique_ptr<TestVariationsServiceClient> client =
- base::WrapUnique(new TestVariationsServiceClient());
+ base::MakeUnique<TestVariationsServiceClient>();
TestVariationsServiceClient* raw_client = client.get();
VariationsService service(
std::move(client),
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs, NULL, UIStringOverrider());
GURL url = service.GetVariationsServerURL(&prefs, std::string());
EXPECT_TRUE(base::StartsWith(url.spec(), default_variations_url,
@@ -395,7 +395,7 @@ TEST_F(VariationsServiceTest, VariationsURLHasOSNameParam) {
TestingPrefServiceSimple prefs;
VariationsService::RegisterPrefs(prefs.registry());
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
const GURL url = service.GetVariationsServerURL(&prefs, std::string());
@@ -411,7 +411,7 @@ TEST_F(VariationsServiceTest, RequestsInitiallyNotAllowed) {
// Pass ownership to TestVariationsService, but keep a weak pointer to
// manipulate it for this test.
std::unique_ptr<web_resource::TestRequestAllowedNotifier> test_notifier =
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs));
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs);
web_resource::TestRequestAllowedNotifier* raw_notifier = test_notifier.get();
TestVariationsService test_service(std::move(test_notifier), &prefs);
@@ -431,7 +431,7 @@ TEST_F(VariationsServiceTest, RequestsInitiallyAllowed) {
// Pass ownership to TestVariationsService, but keep a weak pointer to
// manipulate it for this test.
std::unique_ptr<web_resource::TestRequestAllowedNotifier> test_notifier =
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs));
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs);
web_resource::TestRequestAllowedNotifier* raw_notifier = test_notifier.get();
TestVariationsService test_service(std::move(test_notifier), &prefs);
@@ -445,7 +445,7 @@ TEST_F(VariationsServiceTest, SeedStoredWhenOKStatus) {
VariationsService::RegisterPrefs(prefs.registry());
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.set_intercepts_fetch(false);
@@ -474,7 +474,7 @@ TEST_F(VariationsServiceTest, SeedNotStoredWhenNonOKStatus) {
VariationsService::RegisterPrefs(prefs.registry());
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.set_intercepts_fetch(false);
for (size_t i = 0; i < arraysize(non_ok_status_codes); ++i) {
@@ -496,7 +496,7 @@ TEST_F(VariationsServiceTest, RequestGzipCompressedSeed) {
net::TestURLFetcherFactory factory;
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.set_intercepts_fetch(false);
service.DoActualFetch();
@@ -532,7 +532,7 @@ TEST_F(VariationsServiceTest, InstanceManipulations) {
for (size_t i = 0; i < arraysize(cases); ++i) {
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.set_intercepts_fetch(false);
service.DoActualFetch();
@@ -556,7 +556,7 @@ TEST_F(VariationsServiceTest, CountryHeader) {
VariationsService::RegisterPrefs(prefs.registry());
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
service.set_intercepts_fetch(false);
@@ -579,8 +579,8 @@ TEST_F(VariationsServiceTest, Observer) {
TestingPrefServiceSimple prefs;
VariationsService::RegisterPrefs(prefs.registry());
VariationsService service(
- base::WrapUnique(new TestVariationsServiceClient()),
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<TestVariationsServiceClient>(),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs, NULL, UIStringOverrider());
struct {
@@ -679,8 +679,8 @@ TEST_F(VariationsServiceTest, LoadPermanentConsistencyCountry) {
TestingPrefServiceSimple prefs;
VariationsService::RegisterPrefs(prefs.registry());
VariationsService service(
- base::WrapUnique(new TestVariationsServiceClient()),
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<TestVariationsServiceClient>(),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs, NULL, UIStringOverrider());
if (test.pref_value_before) {
@@ -751,7 +751,7 @@ TEST_F(VariationsServiceTest, OverrideStoredPermanentCountry) {
TestingPrefServiceSimple prefs;
VariationsService::RegisterPrefs(prefs.registry());
TestVariationsService service(
- base::WrapUnique(new web_resource::TestRequestAllowedNotifier(&prefs)),
+ base::MakeUnique<web_resource::TestRequestAllowedNotifier>(&prefs),
&prefs);
if (!test.pref_value_before.empty()) {
« no previous file with comments | « components/variations/service/variations_service.cc ('k') | components/web_resource/web_resource_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698