components/variations/service/variations_service.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/user_prefs/tracked/segregated_pref_store_unittest.cc ('k') | components/variations/service/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/service/variations_service.cc

diff --git a/components/variations/service/variations_service.cc b/components/variations/service/variations_service.cc

index 28b69bd98bb16fe67e7f788bc32627dc57832171..7d32630dbae236b143ebcb44a671a055e3c8c9f3 100644

--- a/components/variations/service/variations_service.cc

+++ b/components/variations/service/variations_service.cc

@@ -502,8 +502,8 @@ std::unique_ptr<VariationsService> VariationsService::Create(

#endif

result.reset(new VariationsService(

std::move(client),

- base::WrapUnique(new web_resource::ResourceRequestAllowedNotifier(

- local_state, disable_network_switch)),

+ base::MakeUnique<web_resource::ResourceRequestAllowedNotifier>(

+ local_state, disable_network_switch),

local_state, state_manager, ui_string_overrider));

return result;

}

@@ -514,8 +514,8 @@ std::unique_ptr<VariationsService> VariationsService::CreateForTesting(

PrefService* local_state) {

return base::WrapUnique(new VariationsService(

std::move(client),

- base::WrapUnique(new web_resource::ResourceRequestAllowedNotifier(

- local_state, nullptr)),

+ base::MakeUnique<web_resource::ResourceRequestAllowedNotifier>(

+ local_state, nullptr),

local_state, nullptr, UIStringOverrider()));

}