components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_sessions/revisit/page_revisit_broadcaster.cc ('k') | components/sync_sessions/revisit/typed_url_page_revisit_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc

diff --git a/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc b/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc

index 179895e35c2cb00551c21a9c82465576c82a3e02..22bbcd3c3df3698df309e98f77ce0025a1c981fc 100644

--- a/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc

+++ b/components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc

@@ -76,7 +76,7 @@ class SessionsPageRevisitObserverTest : public ::testing::Test {

std::vector<const SyncedSession*> sessions;

sessions.push_back(session);

SessionsPageRevisitObserver observer(

- base::WrapUnique(new TestForeignSessionsProvider(sessions, true)));

+ base::MakeUnique<TestForeignSessionsProvider>(sessions, true));

CheckAndExpect(&observer, url, current_match, offset_match);

}

};

@@ -84,7 +84,7 @@ class SessionsPageRevisitObserverTest : public ::testing::Test {

TEST_F(SessionsPageRevisitObserverTest, RunMatchersNoSessions) {

std::vector<const SyncedSession*> sessions;

SessionsPageRevisitObserver observer(

- base::WrapUnique(new TestForeignSessionsProvider(sessions, true)));

+ base::MakeUnique<TestForeignSessionsProvider>(sessions, true));

CheckAndExpect(&observer, GURL(kExampleUrl), false, false);

}

@@ -139,7 +139,7 @@ TEST_F(SessionsPageRevisitObserverTest, RunMatchersFalseProvider) {

std::vector<const SyncedSession*> sessions;

sessions.push_back(session.get());

SessionsPageRevisitObserver observer(

- base::WrapUnique(new TestForeignSessionsProvider(sessions, false)));

+ base::MakeUnique<TestForeignSessionsProvider>(sessions, false));

CheckAndExpect(&observer, GURL(kExampleUrl), false, false);

}

@@ -189,7 +189,7 @@ TEST_F(SessionsPageRevisitObserverTest, RunMatchersMany) {

sessions.push_back(session1.get());

sessions.push_back(session2.get());

SessionsPageRevisitObserver observer(

- base::WrapUnique(new TestForeignSessionsProvider(sessions, true)));

+ base::MakeUnique<TestForeignSessionsProvider>(sessions, true));

base::HistogramTester histogram_tester;

CheckAndExpect(&observer, GURL(kExampleUrl), true, true);